This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32)
ClosedPublic

Authored by luismarques on Nov 25 2019, 9:46 AM.

Details

Summary

Adds tablegen patterns to explicitly handle fcopysign where the magnitude and sign arguments have different types, due to the sign value casts being removed the by DAGCombiner. Support for RV32IF requires a different mechanism. For clarity, it will be added as a separate patch. Adds tests for all relevant scenarios except RV32IF.

Diff Detail

Event Timeline

luismarques created this revision.Nov 25 2019, 9:46 AM
lenary accepted this revision.Nov 25 2019, 9:53 AM

Sure, LGTM

This revision is now accepted and ready to land.Nov 25 2019, 9:53 AM
This revision was automatically updated to reflect the committed changes.