Add default initialization to compressed_pair.

[mvels]

Summary

This change introduces the __default_init_tag to memory, and a corresponding element constructor to allow for default initialization of either of the pair values. This is useful for classes such as std::string where most (all) constructors explitly initialize the values in the constructor.

[mvels]

Friendly ping?

[EricWF]

libcxx/test/std/memory/compressed_pair/compressed_pair.pass.cpp

1 ↗

(On Diff #230719)

This needs to go under test/libcxx because it's libc++ specific.

libcxx/test/std/memory/nothing_to_do.pass.cpp

1 ↗

(On Diff #230719)

Remove this file completely.

[mvels]

Moved compressed_pair,pass.cpp to libcxx test dir

[EricWF]

Committed as 0fa118a9da6786a0aaf81e309d8c3b38bc5f61dd.

libcxx/include/memory

 template <>
 class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX11 auto_ptr<void>
 {
 public:
     typedef void element_type;
 };
 #endif
 
+// Tag used to default initialize one or both of the pair's elements.
+struct __default_init_tag {};
+
 template <class _Tp, int _Idx,
           bool _CanBeEmptyBase =
               is_empty<_Tp>::value && !__libcpp_is_final<_Tp>::value>
 struct __compressed_pair_elem {
   typedef _Tp _ParamT;
   typedef _Tp& reference;
   typedef const _Tp& const_reference;
 
 #ifndef _LIBCPP_CXX03_LANG
   _LIBCPP_INLINE_VISIBILITY constexpr __compressed_pair_elem() : __value_() {}
+  _LIBCPP_INLINE_VISIBILITY constexpr
+  __compressed_pair_elem(__default_init_tag) {}
 
   template <class _Up, class = typename enable_if<
       !is_same<__compressed_pair_elem, typename decay<_Up>::type>::value
   >::type>
   _LIBCPP_INLINE_VISIBILITY
   constexpr explicit
   __compressed_pair_elem(_Up&& __u)
       : __value_(_VSTD::forward<_Up>(__u))
     {
     }
 
   template <class... _Args, size_t... _Indexes>
   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14
   __compressed_pair_elem(piecewise_construct_t, tuple<_Args...> __args,
                          __tuple_indices<_Indexes...>)
       : __value_(_VSTD::forward<_Args>(_VSTD::get<_Indexes>(__args))...) {}
 #else
   _LIBCPP_INLINE_VISIBILITY __compressed_pair_elem() : __value_() {}
   _LIBCPP_INLINE_VISIBILITY
+  __compressed_pair_elem(__default_init_tag) {}
+  _LIBCPP_INLINE_VISIBILITY
   __compressed_pair_elem(_ParamT __p) : __value_(std::forward<_ParamT>(__p)) {}
 #endif
 
   _LIBCPP_INLINE_VISIBILITY reference __get() _NOEXCEPT { return __value_; }
   _LIBCPP_INLINE_VISIBILITY
   const_reference __get() const _NOEXCEPT { return __value_; }
 
 private:

libcxx/test/libcxx/memory/compressed_pair/compressed_pair.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include <assert.h>
+#include <memory>
+
+#include "test_macros.h"
+
+typedef std::__compressed_pair<int, unsigned> IntPair;
+
+void test_constructor() {
+  IntPair value;
+  assert(value.first() == 0);
+  assert(value.second() == 0);
+
+  value.first() = 1;
+  value.second() = 2;
+  new (&value) IntPair;
+  assert(value.first() == 0);
+  assert(value.second() == 0);
+}
+
+void test_constructor_default_init() {
+  IntPair value;
+  value.first() = 1;
+  value.second() = 2;
+
+  new (&value) IntPair(std::__default_init_tag(), 3);
+  assert(value.first() == 1);
+  assert(value.second() == 3);
+
+  new (&value) IntPair(4, std::__default_init_tag());
+  assert(value.first() == 4);
+  assert(value.second() == 3);
+
+  new (&value) IntPair(std::__default_init_tag(), std::__default_init_tag());
+  assert(value.first() == 4);
+  assert(value.second() == 3);
+}
+
+int main(int, char**)
+{
+  test_constructor();
+  test_constructor_default_init();
+  return 0;
+}