User Details
- User Since
- Sep 13 2019, 8:07 AM (211 w, 3 d)
Aug 4 2023
Jul 26 2023
Remove parenthesis from debugging
Fix what I am sure is a bug in checking for max_size() in grow_by_....
Jul 25 2023
BTW: I did not understand the Apple max_size.pass failure, I adjusted the test and they all pass (check-cxx) on my local git repo on x86.
Added extra comments on string growth
Jul 17 2023
Fix headers removed by clang-format mess
Upload correct version this time
Upload grow_by amended changes
Add grow_by without replace
Jul 20 2021
_LIBCPP_ABI_UNSTABLE is meant for improvements (in correctness, performance or other) that require breaking the ABI.
Jul 15 2021
Some 2 cents from my side.
Mar 30 2021
Oct 27 2020
Sorry, didn't see this earlier as this drowned in my email filters :/
Jul 6 2020
Jun 29 2020
Jun 19 2020
I'm going to abandon this diff, seems arcanist, phabricator and I can't see each other eye to eye...... :\ which makes me sad,....
arc diff with --head=HEAD 'HEAD~1'
Running arc diff --update D78763
Looks like harbormaster builds use arcanist, and arcanist has **magic ** making awful diffs?
I'm mystified why the build fails, it fails on applying the patch:
Uploading clean diff
Uploaded clean diff in case harbormaster is confused about diffs
Jun 18 2020
Thanks for the reviews!
Optimed ternary op for ascizz string -> always evalutate length in inlined constant string.
Cleaned up const char* ternary, evaluating traits_type::length for all constant strings
Jun 9 2020
Removed __config changes
Revamped
Fixed __config comment
May 29 2020
Fixed NOEXCEPT comments
renamed end --> pos
Update diff after master pull
Removed Apple V2 abi list
May 27 2020
White space / comment clean up
Fixed AsanTransaction for single 'construct_at' use case
Well, I think we should probably remove that notion, or merge it with the "unstable" ABI. It's not really a thing since V2 is basically unstable AFAICT.
Just fix it and we can improve the situation (i.e. probably remove it) later.
I have no way to verify / test this (cross compiling apple darwin v2 looks to be impossible?), and guessing the mangled names from x86 compiles seems dubious as well given the diffs I see on apple v1 vs linux v1
- Pass this->__end_ to the helper functions
- Return the new end pointer from those helpers
I am skeptical why step 2 is needed at all. You never remove setting of this->__end_. So why do you need to do work that has already been done? Could you please verify that the second part is indeed necessary?
If it is indeed necessary I note that you pessimize the slow path by decrementing and then incrementing.
I would greatly prefer it if you would directly return in both the fast and the slow path.
May 26 2020
May 21 2020
They are removed from the unstable ABI, but not from the ABI v2. Those are different things (and I guess it doesn't really make sense for them to be different). But we should either decide that we don't test abi lists for ABI v2, or fix it. I suggest we fix it for now in order to make progress on this. You just need to update the ABI list for v2, it shouldn't be difficult.
Restricted assign to __min_cap
Fixed external instantiations for unstable (removed __resize)
Simplified change to inlined optimizations.
Apr 23 2020
Added proper constant for min short -> long promotion size
Adjusted for sizeof(value_type)
Apr 10 2020
Mar 4 2020
New diff after rebase
Thanks, arc is not my friend :\ Fixed the diff using --base=git:origin
Thanks, arc is not my friend :\ Fixed the diff using --base=git:origin
BTW, you could argue 'arc' was smart enough to recognize this was a rolled forward revert, and only diff against the original submit, alas :)
Diff against