User Details
- User Since
- Sep 13 2019, 8:07 AM (13 w, 2 d)
Thu, Dec 12
Moved compressed_pair,pass.cpp to libcxx test dir
Wed, Dec 4
Friendly ping?
Friendly ping
Mon, Nov 25
Following discussions with ericwf & ldionne, we be upstreaming these changes incrementally and address the ABI separately
Eric or Marschal, can we land this change? Thanks!
Fri, Nov 22
Nov 8 2019
Thanks Shoaib!
Demonstrating my ignorance on the expected / normal flow of submits here: what is the ETA for this?
Oct 19 2019
Adapt per feature ABI breakage for this change
Oct 16 2019
- fix ifdef for __init_long
- Remove old defines
- Relocate define in __config
I added alternaive DIFF in https://reviews.llvm.org/D69061
Thanks for the elaborate comments Louis!
- Updating D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]) #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
- Updating D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]) #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Oct 13 2019
This change highlights ABI issues (init_long is not a forwards compatible change / technically breaks ABI)
Oct 11 2019
Re split for the alloc case: that may be a good option for a next change, I wanted to keep this change small in scope, and for std::allocator no extra cost / code emitted
Yeah, it's pretty bad though if allocators have throwing move operators, but until c++14 it's 'technically allowed' and something that the std handle gracefully. I was not that alarmed tho, such should be rare, and deserving a halt and catch fire. :)
Oct 9 2019
libc++.so code for std::string ctor (demangled / mixed source)
Oct 7 2019
Here's the godbolt link I am looking at with your code:
- I updated the title
- Added inline
Oct 1 2019
- Merge branch 'master' of https://github.com/llvm/llvm-project into add-benchmarks
- Optimize operator=(const basic_string&) for tail call.
Sep 24 2019
Resolved comments