This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Always set -z now linker option on Fuchsia
ClosedPublic

Authored by phosek on Nov 21 2019, 4:26 PM.

Details

Summary

This should be the default on Fuchsia.

Diff Detail

Event Timeline

phosek created this revision.Nov 21 2019, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2019, 4:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
leonardchan accepted this revision.Nov 21 2019, 5:12 PM

LGTM. But just to confirm, did you test this on CQ/bots by adding ["now", "-z"] as linker flags to the config("compiler") in Fuchsia + Zircon?

This revision is now accepted and ready to land.Nov 21 2019, 5:12 PM

LGTM. But just to confirm, did you test this on CQ/bots by adding ["now", "-z"] as linker flags to the config("compiler") in Fuchsia + Zircon?

https://fuchsia-review.googlesource.com/c/fuchsia/+/342078

This revision was automatically updated to reflect the committed changes.