This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize.
ClosedPublic

Authored by hjyamauchi on Nov 21 2019, 1:51 PM.

Details

Summary

This follows from the discussion at D70095.

D70095 moves hasOptSize calls into SelectionDAG::shouldOptForSize to allow
querying size optimization conditions together with profile guided size
optimization.

Since it appears that size optimizations for WebAssembly SelectionDAG haven't
been implemented yet and thus ForCodeSize is unused, and it would not make a lot
of sense to call shouldOptForSize here as the necessary profile data like
PSI/BFI aren't available at this point, it seems good and less confusing to
remove this for now and use shouldOptForSize when they are implemented in the
future.

Diff Detail

Event Timeline

hjyamauchi created this revision.Nov 21 2019, 1:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2019, 1:51 PM

Can someone suggest reviewers?

aheejin accepted this revision.Nov 21 2019, 2:48 PM
This revision is now accepted and ready to land.Nov 21 2019, 2:48 PM
This revision was automatically updated to reflect the committed changes.