Page MenuHomePhabricator

[llvm-lipo] Implement -extract
ClosedPublic

Authored by alexshap on Nov 20 2019, 6:19 PM.

Details

Summary

This diff adds support for -extract.

Test plan: make check-all

Diff Detail

Event Timeline

alexshap created this revision.Nov 20 2019, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2019, 6:19 PM
smeenai accepted this revision.Nov 20 2019, 7:48 PM

LGTM

This revision is now accepted and ready to land.Nov 20 2019, 7:48 PM
compnerd accepted this revision.Nov 21 2019, 8:42 AM
compnerd added inline comments.
llvm/tools/llvm-lipo/llvm-lipo.cpp
408

Why not hoist this above the architecture check? This should be super cheap, and avoids doing I/O unless the inputs are good.

This revision was automatically updated to reflect the committed changes.