Page MenuHomePhabricator

[lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes
ClosedPublic

Authored by teemperor on Nov 18 2019, 4:03 AM.

Details

Summary

This is some really shady code. It's supposed to kick in after an expression already failed and then try to look
up "unknown types" that for some undocumented reason can't be resolved during/before parsing. Beside the
fact that we never mark any type as EVUnknownType in either swift-lldb or lldb (which means this code is unreachable),
this code doesn't even make the expression evaluation succeed if if would ever be executed but instead seems
to try to load more debug info that maybe any following expression evaluations might succeed.

This patch removes ClangExpressionDeclMap::ResolveUnknownTypes and the related data structures/checks/calls.

Diff Detail

Event Timeline

teemperor created this revision.Nov 18 2019, 4:03 AM
davide accepted this revision.Nov 18 2019, 9:47 AM
This revision is now accepted and ready to land.Nov 18 2019, 9:47 AM
This revision was automatically updated to reflect the committed changes.