This is an archive of the discontinued LLVM Phabricator instance.

test-release.sh: Update to fetch source from GitHub
ClosedPublic

Authored by tstellar on Nov 15 2019, 6:23 PM.

Details

Summary

This also changes the test-release.sh script to build using the monorepo layout instead of copying sub-projects into llvm/tools or llvm/projects.

Event Timeline

tstellar created this revision.Nov 15 2019, 6:23 PM
Herald added a project: Restricted Project. · View Herald Transcript
hans edited reviewers, added: hans; removed: hansw.Nov 18 2019, 12:10 AM
hans added a subscriber: hans.

Thanks for digging into this!

llvm/utils/release/test-release.sh
304–305

I guess this won't work with -svn-path, which I like to use to test a branch before tagging it.

It would be great if we could rename that to -git-ref or something and have it work the same way.

306

Could we just pipe it to tar directly? Then there would be no need to come up with a name for the file or to keep it around.

309

Maybe add a comment here for those not familiar with the GitHub API?

371–372

Maybe add to the change description that this changes the build to use the monorpo layout. (It makes sense now that we're getting the source from GitHub, but I think it's worth calling it out explicitly.)
Also this is the post I'm most curious about. Hopefully it doesn't cause problems :-)

tstellar updated this revision to Diff 229888.Nov 18 2019, 11:25 AM

Address some review comments.

tstellar edited the summary of this revision. (Show Details)Nov 18 2019, 11:28 AM
tstellar marked 4 inline comments as done.
tstellar added inline comments.
llvm/utils/release/test-release.sh
304–305

I've added an equivalent option called -git-ref. The only difference is if you pass it a raw sha, then it won't be able to checkout the test-suite, since it is in a different repository.

hans accepted this revision.Nov 18 2019, 11:56 AM

Looks great to me. Thanks!

llvm/utils/release/test-release.sh
310

Nit: :: -> :, and achive -> archive.

This revision is now accepted and ready to land.Nov 18 2019, 11:56 AM
This revision was automatically updated to reflect the committed changes.