This is an archive of the discontinued LLVM Phabricator instance.

Fix TestFormatters.py stepping too far
ClosedPublic

Authored by rovka on Nov 15 2019, 3:54 AM.

Details

Summary

TestFormatters.py has a sequence of three 'next' commands to get past
all the initializations in the test function. On AArch64 (and
potentially other platforms), this was one 'next' too many and we ended
up outside our frame.

This patch replaces the sequence with a 'thread until ' the line of the
return from the function, so we should stop after all the
initializations but before actually returning.

Diff Detail

Event Timeline

rovka created this revision.Nov 15 2019, 3:54 AM
labath added a subscriber: labath.Nov 15 2019, 4:07 AM

Looks reasonable, but I'd suggest using something more unique for the breakpoint placement. Feel free to add some comment to the .cpp file and then search for that in python (that's what most of our other tests tend to do).

rovka updated this revision to Diff 229505.Nov 15 2019, 4:17 AM

Addressed @labath's comment (test run in progress). Thanks for having a look!

labath accepted this revision.Nov 15 2019, 4:20 AM
This revision is now accepted and ready to land.Nov 15 2019, 4:20 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2019, 5:26 AM