[OPENMP50]Add device/kind context selector support.
ClosedPublic
Actions

Authored by ABataev on Thu, Nov 14, 8:17 AM.

Details

Reviewers

jdoerfert

Commits

Summary

Added basic parsing/sema support for device/kind context selector.

clang/lib/CodeGen/CGOpenMPRuntime.cpp
11249	Nit: `bool RHSIsSubsetOfLHS = isStrictSubset(RHS, LHS)` saves you a line later.
clang/test/OpenMP/declare_variant_device_kind_codegen.cpp
82	What is wrong about cpu, gpu together?

ABataev marked an inline comment as done.Fri, Nov 15, 6:24 PM

ABataev added inline comments.

clang/test/OpenMP/declare_variant_device_kind_codegen.cpp
82	When several traits sre used, the logic and is applied. So, cpu,gpu means that the target is cpu and gpu at the same time.

Address comment

More comments?

LGTM.

This revision is now accepted and ready to land.Thu, Nov 21, 9:11 AM

This revision was automatically updated to reflect the committed changes.

This comment was removed by jdoerfert.

		Path
M		clang/include/clang/Basic/Attr.td (26 lines)
M		clang/include/clang/Basic/DiagnosticParseKinds.td (3 lines)
M		clang/include/clang/Basic/OpenMPKinds.def (2 lines)
M		clang/lib/CodeGen/CGOpenMPRuntime.cpp (193 lines)
M		clang/lib/Parse/ParseOpenMP.cpp (89 lines)
M		clang/lib/Sema/SemaOpenMP.cpp (30 lines)
M		clang/lib/Sema/SemaTemplateInstantiateDecl.cpp (11 lines)
M		clang/test/OpenMP/declare_variant_ast_print.c (16 lines)
M		clang/test/OpenMP/declare_variant_ast_print.cpp (80 lines)
A	M	clang/test/OpenMP/declare_variant_device_kind_codegen.cpp (187 lines)
M		clang/test/OpenMP/declare_variant_messages.c (13 lines)
M		clang/test/OpenMP/declare_variant_messages.cpp (22 lines)
A	M	clang/test/OpenMP/declare_variant_mixed_codegen.cpp (137 lines)
A	M	clang/test/OpenMP/nvptx_declare_variant_device_kind_codegen.cpp (170 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	229315	232cdb3		Thu, Nov 14, 8:17 AM	★	★
Diff 2	229843	dea8f3b	Address comment	Mon, Nov 18, 7:24 AM	★	★
Diff 3	230488	70d173f	rG4e8231b5cf0f5f62c7a51a857e29f5be5cb55734	Thu, Nov 21, 10:28 AM	★	★