Page MenuHomePhabricator

[OPENMP50]Add device/kind context selector support.
ClosedPublic

Authored by ABataev on Thu, Nov 14, 8:17 AM.

Details

Summary

Added basic parsing/sema support for device/kind context selector.

Diff Detail

Event Timeline

ABataev created this revision.Thu, Nov 14, 8:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 14, 8:17 AM
jdoerfert added inline comments.Fri, Nov 15, 6:19 PM
clang/lib/CodeGen/CGOpenMPRuntime.cpp
11249

Nit: bool RHSIsSubsetOfLHS = isStrictSubset(RHS, LHS)
saves you a line later.

clang/test/OpenMP/declare_variant_device_kind_codegen.cpp
82

What is wrong about cpu, gpu together?

ABataev marked an inline comment as done.Fri, Nov 15, 6:24 PM
ABataev added inline comments.
clang/test/OpenMP/declare_variant_device_kind_codegen.cpp
82

When several traits sre used, the logic and is applied. So, cpu,gpu means that the target is cpu and gpu at the same time.

ABataev updated this revision to Diff 229843.Mon, Nov 18, 7:24 AM

Address comment

More comments?

This revision is now accepted and ready to land.Thu, Nov 21, 9:11 AM
This revision was automatically updated to reflect the committed changes.
This comment was removed by jdoerfert.