This is an archive of the discontinued LLVM Phabricator instance.

Differential D7023

Add LLVM_LINK_COMPONENTS for the shared object build
ClosedPublic

Authored by garious on Jan 16 2015, 2:30 PM.

Details

Reviewers
kledzik
ruiu
Bigcheese
Commits
rGc7a815bb3a1a: Add LLVM_LINK_COMPONENTS for the shared object build
rLLD226346: Add LLVM_LINK_COMPONENTS for the shared object build
Summary

Configuring with -DBUILD_SHARED_LIBS=ON causes lots of linker errors in lld. This patch fixes all the missing dependencies on LLVM libraries.

Diff Detail

Repository
rL LLVM

Event Timeline

garious updated this revision to Diff 18323.Jan 16 2015, 2:30 PM
garious retitled this revision from to Add LLVM_LINK_COMPONENTS for the shared object build.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added a reviewer: ruiu.
garious set the repository for this revision to rL LLVM.
garious added a project: lld.
garious added a subscriber: Unknown Object (MLST).
ruiu added reviewers: Bigcheese, kledzik.Jan 16 2015, 2:51 PM
ruiu edited edge metadata.Jan 16 2015, 2:52 PM

My knowledge on the build system is limited, so I added a few more
reviewers.

Bigcheese accepted this revision.Jan 16 2015, 3:06 PM
Bigcheese edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jan 16 2015, 3:06 PM
garious closed this revision.Jan 19 2015, 9:12 AM

r226346

Revision Contents

PathSize
lib/
Config/
2 lines
Driver/
2 lines
Passes/
2 lines
ReaderWriter/
2 lines
ELF/
AArch64/
2 lines
Hexagon/
2 lines
Mips/
2 lines
PPC/
2 lines
X86/
2 lines
X86_64/
2 lines
MachO/
2 lines
Native/
2 lines
PECOFF/
2 lines
YAML/
2 lines

Diff 18323

lib/Config/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldConfig add_lld_library(lldConfig
Version.cpp Version.cpp
) )

lib/Driver/CMakeLists.txt

Context not available.
tablegen(LLVM WinLinkOptions.inc -gen-opt-parser-defs) tablegen(LLVM WinLinkOptions.inc -gen-opt-parser-defs)
add_public_tablegen_target(DriverOptionsTableGen) add_public_tablegen_target(DriverOptionsTableGen)
set(LLVM_LINK_COMPONENTS object option support)
add_lld_library(lldDriver add_lld_library(lldDriver
CoreDriver.cpp CoreDriver.cpp
DarwinLdDriver.cpp DarwinLdDriver.cpp
Context not available.

lib/Passes/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldPasses add_lld_library(lldPasses
LayoutPass.cpp LayoutPass.cpp
RoundTripNativePass.cpp RoundTripNativePass.cpp

lib/ReaderWriter/CMakeLists.txt

Context not available.
add_subdirectory(PECOFF) add_subdirectory(PECOFF)
add_subdirectory(YAML) add_subdirectory(YAML)
set(LLVM_LINK_COMPONENTS object) set(LLVM_LINK_COMPONENTS object support)
add_lld_library(lldReaderWriter add_lld_library(lldReaderWriter
CoreLinkingContext.cpp CoreLinkingContext.cpp
Context not available.

lib/ReaderWriter/ELF/AArch64/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldAArch64ELFTarget add_lld_library(lldAArch64ELFTarget
AArch64LinkingContext.cpp AArch64LinkingContext.cpp
AArch64TargetHandler.cpp AArch64TargetHandler.cpp

lib/ReaderWriter/ELF/Hexagon/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldHexagonELFTarget add_lld_library(lldHexagonELFTarget
HexagonLinkingContext.cpp HexagonLinkingContext.cpp
HexagonRelocationHandler.cpp HexagonRelocationHandler.cpp

lib/ReaderWriter/ELF/Mips/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldMipsELFTarget add_lld_library(lldMipsELFTarget
MipsCtorsOrderPass.cpp MipsCtorsOrderPass.cpp
MipsELFFlagsMerger.cpp MipsELFFlagsMerger.cpp

lib/ReaderWriter/ELF/PPC/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldPPCELFTarget add_lld_library(lldPPCELFTarget
PPCLinkingContext.cpp PPCLinkingContext.cpp
PPCTargetHandler.cpp PPCTargetHandler.cpp

lib/ReaderWriter/ELF/X86/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldX86ELFTarget add_lld_library(lldX86ELFTarget
X86LinkingContext.cpp X86LinkingContext.cpp
X86TargetHandler.cpp X86TargetHandler.cpp

lib/ReaderWriter/ELF/X86_64/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldX86_64ELFTarget add_lld_library(lldX86_64ELFTarget
X86_64LinkingContext.cpp X86_64LinkingContext.cpp
X86_64TargetHandler.cpp X86_64TargetHandler.cpp

lib/ReaderWriter/MachO/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldMachO add_lld_library(lldMachO
ArchHandler.cpp ArchHandler.cpp
ArchHandler_arm.cpp ArchHandler_arm.cpp

lib/ReaderWriter/Native/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldNative add_lld_library(lldNative
ReaderNative.cpp ReaderNative.cpp
WriterNative.cpp WriterNative.cpp

lib/ReaderWriter/PECOFF/CMakeLists.txt

set(LLVM_LINK_COMPONENTS object support)
add_lld_library(lldPECOFF add_lld_library(lldPECOFF
EdataPass.cpp EdataPass.cpp
IdataPass.cpp IdataPass.cpp

lib/ReaderWriter/YAML/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support)
add_lld_library(lldYAML add_lld_library(lldYAML
ReaderWriterYAML.cpp ReaderWriterYAML.cpp
) )