Page MenuHomePhabricator

garious (Greg Fitzgerald)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 16 2012, 5:35 PM (356 w, 2 d)

Recent Activity

Feb 24 2015

garious abandoned D7625: [lld] Revive standalone CMake build.

Seems I'm the only one that wants this, abandoning. That's too bad. Standalone builds are really nice in component-oriented builds, especially when managing multiple build variations. Unfortunately, all my code that demonstrates this is locked inside our company. Oh well - perhaps another day.

Feb 24 2015, 1:26 PM · lld
garious added a comment to D7843: [lld] cmake cleanup.

LGTM. cmake_minimum_required() can be moved into the Standalone conditional, if that is ever added back in.

Feb 24 2015, 1:16 PM

Feb 23 2015

garious added a comment to D7625: [lld] Revive standalone CMake build.

Ping

Feb 23 2015, 9:39 AM · lld

Feb 21 2015

garious added a comment to D7807: [lld] Remove duplicate class definitions of ELF LinkingContexts.

LLD is in an awkward limbo state where it acts like it's a first-class member of the LLVM tree and also acts like an independent project that only depends on LLVM for its Support and CMake libraries. If it wants to be the former, LLD should respect LLVM_TARGETS_TO_BUILD. If the latter, it doesn't matter and could have its own Targets.def. But if that's the case, LLD should have a standalone CMake build.

Feb 21 2015, 10:34 AM · lld

Feb 20 2015

garious retitled D7807: [lld] Remove duplicate class definitions of ELF LinkingContexts from to [lld] Remove duplicate class definitions of ELF LinkingContexts.
Feb 20 2015, 10:28 PM · lld
garious added a comment to D7625: [lld] Revive standalone CMake build.

Ping

Feb 20 2015, 7:16 AM · lld

Feb 19 2015

garious added a comment to D7733: [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer.

@kcc, I'll see what I can do. Let's continue this discussion on llvmdev. LLD is now free of ASan errors, but I haven't yet had a chance to evaluate MSan. By the looks of those scripts, I should probably fix up any MSan-reported bugs before lighting up that bot.

Feb 19 2015, 12:55 PM · lld
garious committed rL229912: Fix heap-buffer-overflow bugs identified by the Address Sanitizer.
Fix heap-buffer-overflow bugs identified by the Address Sanitizer
Feb 19 2015, 12:44 PM
garious closed D7733: [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer by committing rL229912: Fix heap-buffer-overflow bugs identified by the Address Sanitizer.
Feb 19 2015, 12:44 PM · lld
garious added reviewers for D7625: [lld] Revive standalone CMake build: chandlerc, chapuni.
Feb 19 2015, 10:28 AM · lld
garious added a comment to D7625: [lld] Revive standalone CMake build.

Ping

Feb 19 2015, 10:27 AM · lld

Feb 18 2015

garious added a comment to D7733: [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer.

To my knowledge, there isn't an ASan bot for LLD.

Feb 18 2015, 6:33 PM · lld
garious updated the diff for D7733: [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer.

Cleanup, per Rafael's feedback.

Feb 18 2015, 3:26 PM · lld
garious committed rL229749: Fix use-after-free bug identified by the Address Sanitizer.
Fix use-after-free bug identified by the Address Sanitizer
Feb 18 2015, 1:56 PM
garious closed D7732: [lld] Fix use-after-free bug identified by the Address Sanitizer by committing rL229749: Fix use-after-free bug identified by the Address Sanitizer.
Feb 18 2015, 1:56 PM · lld
garious retitled D7733: [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer from to [lld] Fix heap-buffer-overflow bugs identified by the Address Sanitizer.
Feb 18 2015, 12:35 PM · lld
garious retitled D7732: [lld] Fix use-after-free bug identified by the Address Sanitizer from to [lld] Fix use-after-free bug identified by the Address Sanitizer.
Feb 18 2015, 12:01 PM · lld
garious committed rL229714: [ASan] Set DYLD_LIBRARY_PATH on Darwin.
[ASan] Set DYLD_LIBRARY_PATH on Darwin
Feb 18 2015, 10:29 AM
garious closed D7706: [ASan] set DYLD_LIBRARY_PATH on Darwin by committing rL229714: [ASan] Set DYLD_LIBRARY_PATH on Darwin.
Feb 18 2015, 10:29 AM
garious added a comment to D7625: [lld] Revive standalone CMake build.

Still waiting on a second review. @Bigcheese, @nicholas?

Feb 18 2015, 10:21 AM · lld

Feb 17 2015

garious retitled D7706: [ASan] set DYLD_LIBRARY_PATH on Darwin from to [ASan] set DYLD_LIBRARY_PATH on Darwin.
Feb 17 2015, 3:20 PM
garious added a comment to D7625: [lld] Revive standalone CMake build.

Can others please review? Thanks.

Feb 17 2015, 10:38 AM · lld

Feb 13 2015

garious added inline comments to D7625: [lld] Revive standalone CMake build.
Feb 13 2015, 3:48 PM · lld
garious added inline comments to D7625: [lld] Revive standalone CMake build.
Feb 13 2015, 3:21 PM · lld
garious retitled D7625: [lld] Revive standalone CMake build from to [lld] Revive standalone CMake build.
Feb 13 2015, 2:17 PM · lld

Feb 5 2015

garious closed D7446: [libcxxabi] Install header files.

Thanks! Committed in r228351

Feb 5 2015, 2:49 PM
garious committed rL228351: Install header files.
Install header files
Feb 5 2015, 2:48 PM
garious added a reviewer for D7446: [libcxxabi] Install header files: jroelofs.
Feb 5 2015, 2:39 PM
garious retitled D7446: [libcxxabi] Install header files from to [libcxxabi] Install header files.
Feb 5 2015, 11:58 AM

Feb 3 2015

garious committed rL228005: Don't assume LIT_EXECUTABLE points to a Python script, take 2.
Don't assume LIT_EXECUTABLE points to a Python script, take 2
Feb 3 2015, 10:49 AM
garious committed rL227996: Revert "Don't assume LIT_EXECUTABLE points to a Python script".
Revert "Don't assume LIT_EXECUTABLE points to a Python script"
Feb 3 2015, 10:18 AM
garious committed rL227994: Don't assume LIT_EXECUTABLE points to a Python script.
Don't assume LIT_EXECUTABLE points to a Python script
Feb 3 2015, 10:03 AM
garious closed D7315: [libcxx] Don't assume LIT_EXECUTABLE points to a Python script by committing rL227994: Don't assume LIT_EXECUTABLE points to a Python script.
Feb 3 2015, 10:03 AM

Jan 31 2015

garious retitled D7315: [libcxx] Don't assume LIT_EXECUTABLE points to a Python script from to [libcxx] Don't assume LIT_EXECUTABLE points to a Python script.
Jan 31 2015, 9:23 AM

Jan 30 2015

garious abandoned D7229: [lld] Merge X86 ELF directories.

I think I was only looking at this from the perspective of the build and not from the developer. Since the two targets are conceptually distinct, I don't want to create confusion by merging the directories.

Jan 30 2015, 3:33 PM · lld
garious added a comment to D7229: [lld] Merge X86 ELF directories.

So it doesn't look like there's much interest in moving lld into the llvm repo, but I'd still like to move forward with supporting LLVM_TARGETS_TO_BUILD. Here's what needs to be done:

Jan 30 2015, 1:39 PM · lld

Jan 28 2015

garious updated subscribers of D7212: [MachO] Implement -order_file as a separate ordering pass..
Jan 28 2015, 1:03 PM · lld
garious added a comment to D7229: [lld] Merge X86 ELF directories.

No, we don't have to do this. We don't have to do anything. This is open source!

Jan 28 2015, 11:29 AM · lld
garious retitled D7229: [lld] Merge X86 ELF directories from to [lld] Merge X86 ELF directories.
Jan 28 2015, 10:06 AM · lld
garious committed rL227320: Remove PPC ELF target.
Remove PPC ELF target
Jan 28 2015, 8:39 AM
garious closed D7225: [lld] Remove PPC ELF target by committing rL227320: Remove PPC ELF target.
Jan 28 2015, 8:39 AM · lld
garious retitled D7225: [lld] Remove PPC ELF target from to [lld] Remove PPC ELF target.
Jan 28 2015, 5:09 AM · lld
garious updated subscribers of D7223: [lld][ARM] Add relocations to perform function calls.
Jan 28 2015, 3:50 AM · lld

Jan 26 2015

garious committed rL227134: Fix shared library build.
Fix shared library build
Jan 26 2015, 12:48 PM
garious closed D7185: [lld] Fix shared libraries build by committing rL227134: Fix shared library build.
Jan 26 2015, 12:48 PM · lld
garious retitled D7185: [lld] Fix shared libraries build from to [lld] Fix shared libraries build.
Jan 26 2015, 12:06 PM · lld

Jan 23 2015

garious added a comment to D7119: [lld] Fix the ELF shared library build targets.

Should be fixed in r226989.

Jan 23 2015, 8:54 PM · lld
garious committed rL226989: Fix single-arch builds broken by r226976.
Fix single-arch builds broken by r226976
Jan 23 2015, 8:53 PM
garious closed D7119: [lld] Fix the ELF shared library build targets.
Jan 23 2015, 5:12 PM · lld
garious closed D7155: [lld] Break cyclic dependency between lldDriver and lldMachO.
Jan 23 2015, 5:12 PM · lld
garious committed rL226976: Fix the ELF shared library build targets - take 2.
Fix the ELF shared library build targets - take 2
Jan 23 2015, 5:08 PM
garious committed rL226963: [MachO] Remove dependency on lldDriver.
[MachO] Remove dependency on lldDriver
Jan 23 2015, 3:27 PM
garious added inline comments to D7155: [lld] Break cyclic dependency between lldDriver and lldMachO.
Jan 23 2015, 3:21 PM · lld
garious retitled D7155: [lld] Break cyclic dependency between lldDriver and lldMachO from to [lld] Break cyclic dependency between lldDriver and lldMachO.
Jan 23 2015, 3:08 PM · lld
garious updated the diff for D7119: [lld] Fix the ELF shared library build targets.

This version constructs the LinkingContext with static methods and a class factory. The previous version would blow up if a LinkingContext contained member variables.

Jan 23 2015, 2:57 PM · lld
garious committed rL226928: Revert " Fix the ELF shared library build targets".
Revert " Fix the ELF shared library build targets"
Jan 23 2015, 11:26 AM
garious committed rL226922: Fix the ELF shared library build targets.
Fix the ELF shared library build targets
Jan 23 2015, 10:54 AM
garious added a comment to D7119: [lld] Fix the ELF shared library build targets.

Rui, any objections?

Jan 23 2015, 9:51 AM · lld

Jan 22 2015

garious updated the diff for D7119: [lld] Fix the ELF shared library build targets.

This version leaves the targets' LinkingContext headers in their respective source directories and instead follows the pattern from the LLVM repo, which is to generate a header from the build configuration.

Jan 22 2015, 4:46 PM · lld
garious added a comment to D7119: [lld] Fix the ELF shared library build targets.

The reason I moved the headers is because the driver needs access each target's LinkingContext constructor. Before this patch, that code was in lldELF which created a cyclic dependency.

Jan 22 2015, 3:06 PM · lld
garious added a comment to D7119: [lld] Fix the ELF shared library build targets.

We could, but that would diverge from the way the LLVM repo is organized. I think a good compromise here would be to move all method implementations into each public header's respective .cpp file. Would you like me to do that as part of this patch?

Jan 22 2015, 11:57 AM · lld
garious added a comment to D7119: [lld] Fix the ELF shared library build targets.

Hi Shankar,

Jan 22 2015, 11:44 AM · lld
garious updated the diff for D7119: [lld] Fix the ELF shared library build targets.

Per Shankar, tuck all ELF includes in one header that the Driver then includes.

Jan 22 2015, 11:35 AM · lld

Jan 21 2015

garious retitled D7119: [lld] Fix the ELF shared library build targets from to [lld] Fix the ELF shared library build targets.
Jan 21 2015, 10:01 PM · lld
garious committed rL226782: Add ARM backend to the autotools build.
Add ARM backend to the autotools build
Jan 21 2015, 9:14 PM
garious committed rL226732: Fix five of the shared library build targets.
Fix five of the shared library build targets
Jan 21 2015, 2:56 PM
garious closed D7105: [lld] Fix five of the shared-lib builds.

Committed in r226732. Thanks!

Jan 21 2015, 2:56 PM · lld
garious closed D7074: [lld] Boot bitrotting add_lld_library() from CMake build.

Committed in r226702. Thanks!

Jan 21 2015, 1:29 PM · lld
garious committed rL226702: add_lld_library -> add_llvm_library.
add_lld_library -> add_llvm_library
Jan 21 2015, 1:28 PM
garious retitled D7105: [lld] Fix five of the shared-lib builds from to [lld] Fix five of the shared-lib builds.
Jan 21 2015, 12:00 PM · lld
garious updated the diff for D7074: [lld] Boot bitrotting add_lld_library() from CMake build.

There will be follow-up patches to continue fixing link-time dependences, but I'd prefer to land this one first to avoid rebasing. It aims to be noncontroversial, whereas experiments in the follow-up patches are starting to look pretty insane. I think it'll have to be broken up into smaller patches as well.

Jan 21 2015, 10:55 AM · lld
garious added a comment to D7074: [lld] Boot bitrotting add_lld_library() from CMake build.

Rafael, now that the standalone CMake build is gone, we can assume lld is a subdirectory of the llvm source tree. I'd like to proceed as though the lld will eventually be fully integrated. We therefore do not need the feature of clang's wrapper, which is to retarget the install directory.

Jan 21 2015, 10:44 AM · lld

Jan 20 2015

garious closed D6716: [lld][ELF]: Minimal implementation for ARM static linking.
Jan 20 2015, 11:38 PM · lld
garious added a comment to D6716: [lld][ELF]: Minimal implementation for ARM static linking.

Committed in r226643. Thanks!

Jan 20 2015, 11:38 PM · lld
garious committed rL226643: [ELF] Minimal implementation for ARM static linking.
[ELF] Minimal implementation for ARM static linking
Jan 20 2015, 11:37 PM
garious added a comment to D6716: [lld][ELF]: Minimal implementation for ARM static linking.

Thanks. I'm afraid we won't be able to reassign the author field in the git mirror until the next llvm.org update. I'll go ahead and land this patch now.

Jan 20 2015, 11:19 PM · lld
garious added a comment to D7074: [lld] Boot bitrotting add_lld_library() from CMake build.

To #1: that's why this patch stops here. We can move exactly this far before having that discussion.

Jan 20 2015, 3:38 PM · lld
garious updated the diff for D7074: [lld] Boot bitrotting add_lld_library() from CMake build.

Per Chandler, use add_llvm_library directly. Also, fix most of the shared library build on OS X. This is as much as I can fix without splitting the ReaderWriter library. I plan to do that right after this patch lands.

Jan 20 2015, 3:07 PM · lld
garious retitled D7074: [lld] Boot bitrotting add_lld_library() from CMake build from to [lld] Boot bitrotting add_lld_library() from CMake build.
Jan 20 2015, 2:02 PM · lld
garious added a comment to D6716: [lld][ELF]: Minimal implementation for ARM static linking.

Thanks for your patience. Could you please rebase your change on the latest? r226557 changed the TargetRelocationHandler and removed unhandledReferenceType().

Jan 20 2015, 9:55 AM · lld

Jan 19 2015

garious added a comment to D6716: [lld][ELF]: Minimal implementation for ARM static linking.

Hi Denis, I've volunteered to land this patch. Due to the size of the contribution, I'd like to put some extra effort into ensuring that your name ends up in the Author field on the git mirror. If we're able to configure git-svn to do that, I hope we can have it done and this patch landed in the next day or two. If you'd rather see it land today and don't mind my name stamped all over "git blame" output, I can go ahead and pull the trigger immediately. Please let me know your preference.

Jan 19 2015, 11:24 AM · lld
garious closed D6877: AArch64 : Implement GHC calling convention..

Committed in r226473. Renato, I added the CHECK-LABEL you mentioned.

Jan 19 2015, 9:43 AM
garious committed rL226473: [AArch64] Implement GHC calling convention.
[AArch64] Implement GHC calling convention
Jan 19 2015, 9:41 AM
garious closed D7023: Add LLVM_LINK_COMPONENTS for the shared object build.

r226346

Jan 19 2015, 9:12 AM · lld

Jan 17 2015

garious updated subscribers of D6716: [lld][ELF]: Minimal implementation for ARM static linking.
Jan 17 2015, 10:37 PM · lld

Jan 16 2015

garious committed rL226346: Add LLVM_LINK_COMPONENTS for the shared object build.
Add LLVM_LINK_COMPONENTS for the shared object build
Jan 16 2015, 3:36 PM
garious retitled D7023: Add LLVM_LINK_COMPONENTS for the shared object build from to Add LLVM_LINK_COMPONENTS for the shared object build.
Jan 16 2015, 2:30 PM · lld

Jan 12 2015

garious added reviewers for D6877: AArch64 : Implement GHC calling convention.: rengolin, grosbach, weimingz, dpeixott.
Jan 12 2015, 10:06 PM
garious added a comment to D6877: AArch64 : Implement GHC calling convention..

Thanks Erik. Good test and looks consistent with the X86_64 implementation. I'll try to find one more person to review. Hopefully we can land this one soon.

Jan 12 2015, 10:04 PM
garious committed rL225739: Remove fragile regex from test.
Remove fragile regex from test
Jan 12 2015, 4:13 PM
garious closed D6937: [lld] Remove fragile regex from test by committing rL225739: Remove fragile regex from test.
Jan 12 2015, 4:13 PM · lld
garious added inline comments to D6937: [lld] Remove fragile regex from test.
Jan 12 2015, 3:39 PM · lld
garious updated the diff for D6937: [lld] Remove fragile regex from test.

Attempt 2: Use a regex that accepts any set of characters that ends in a [back]slash.

Jan 12 2015, 3:36 PM · lld
garious added inline comments to D6937: [lld] Remove fragile regex from test.
Jan 12 2015, 3:24 PM · lld
garious retitled D6937: [lld] Remove fragile regex from test from to [lld] Remove fragile regex from test.
Jan 12 2015, 2:50 PM · lld
garious committed rL225704: Remove CMake standalone build configuration.
Remove CMake standalone build configuration
Jan 12 2015, 1:42 PM
garious closed D6898: [lld] Remove CMake standalone build configuration by committing rL225704: Remove CMake standalone build configuration.
Jan 12 2015, 1:42 PM · lld
garious added a comment to D6898: [lld] Remove CMake standalone build configuration.

Ping

Jan 12 2015, 11:20 AM · lld

Jan 9 2015

garious committed rL225574: Don't fail if parent directory name contains a '+' character.
Don't fail if parent directory name contains a '+' character
Jan 9 2015, 6:35 PM
garious closed D6902: [lld] Don't fail if parent directory contains a '+' character by committing rL225574: Don't fail if parent directory name contains a '+' character.
Jan 9 2015, 6:35 PM · lld