Page MenuHomePhabricator

[Object][RISCV] Resolve R_RISCV_32_PCREL
ClosedPublic

Authored by luismarques on Nov 13 2019, 12:38 PM.

Details

Summary

Add support for resolving R_RISCV_32_PCREL relocations. Those aren't actually resolved AFAIK, but support is still needed to avoid llvm-dwarfdump errors. The use of these relocations was introduced in D66419 but the corresponding resolving wasn't added then*. The test adds a check that should catch future unresolved relocations.

*I would blame the reviewer, but it turns out that person was me, so he's exculpated.

Diff Detail

Event Timeline

luismarques created this revision.Nov 13 2019, 12:38 PM
asb accepted this revision.Nov 21 2019, 4:46 AM

LGTM, thanks Luis.

This revision is now accepted and ready to land.Nov 21 2019, 4:46 AM
luismarques retitled this revision from [DWARF][RISCV] Resolve R_RISCV_32_PCREL to [Object][RISCV] Resolve R_RISCV_32_PCREL.

Rebase patch; Tweak enumeration order. Change title [DWARF] to [Object].

This revision was automatically updated to reflect the committed changes.