This is an archive of the discontinued LLVM Phabricator instance.

Fix use of add_llvm_tool in projects that build no targets
ClosedPublic

Authored by kpet on Nov 13 2019, 1:39 AM.

Details

Reviewers
svenvh
Summary

Projects that set LLVM_TARGETS_TO_BUILD to an empty list
can't use add_llvm_tool (and probably other macros).

Here's the error that this change fixes:

list sub-command REMOVE_ITEM requires two or more arguments.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>

Diff Detail

Event Timeline

kpet created this revision.Nov 13 2019, 1:39 AM
svenvh accepted this revision.Nov 14 2019, 2:40 AM

LGTM!

This revision is now accepted and ready to land.Nov 14 2019, 2:40 AM
kpet closed this revision.Nov 14 2019, 4:50 AM

Committed as e73177ea5fd611026abcbaecc6232eee8d8d2ed8.