Page MenuHomePhabricator

[Driver][FreeBSD] Enable unwind tables on !amd64
ClosedPublic

Authored by cem on Nov 11 2019, 10:35 PM.

Details

Summary

There doesn't seem to be much sense in defaulting "on" unwind tables on
amd64 and not on other arches. It causes surprising differences between
platforms, such as the PR below.

Prior to this change, FreeBSD inherited the default implementation of the
method from the Gnu.h Generic_Elf => Generic_GCC parent class, which
returned true only for amd64 targets. Override that and opt on always,
similar to, e.g., NetBSD's driver.

A simple test case for a !amd64 architecture is added to the "freebsd.c"
tests.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241562

Diff Detail

Event Timeline

cem created this revision.Nov 11 2019, 10:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2019, 10:35 PM
dim accepted this revision.Nov 12 2019, 10:03 AM

LGTM

This revision is now accepted and ready to land.Nov 12 2019, 10:03 AM
This revision was automatically updated to reflect the committed changes.