Page MenuHomePhabricator

[X86] Add more add/sub carry tests
ClosedPublic

Authored by davezarzycki on Nov 11 2019, 5:51 AM.

Details

Summary

I have a forthcoming patch that folds UADDO/USUBO carry in/out diamonds into ISD::ADDCARRY/ISD::SUBCARRY, but first, we need more "before" tests to show the benefit of this change.

Diff Detail

Event Timeline

davezarzycki created this revision.Nov 11 2019, 5:51 AM
RKSimon added inline comments.Nov 11 2019, 6:24 AM
test/CodeGen/X86/addcarry.ll
419

strip all the dso_local and local_unnamed_addr #0 tags?

davezarzycki added a subscriber: uweigand.

Removed dso_local and local_unnamed_addr #0 tags. Also updated the System Z tests based to not be overly strict based on feedback from @uweigand.

SystemZ parts LGTM.

RKSimon accepted this revision.Nov 12 2019, 1:24 AM

LGTM - cheers

This revision is now accepted and ready to land.Nov 12 2019, 1:24 AM