Page MenuHomePhabricator

[InstCombine] Don't transform bitcasts between x86_mmx and v1i64 into insertelement/extractelement
ClosedPublic

Authored by craig.topper on Thu, Nov 7, 1:18 PM.

Details

Summary

x86_mmx is conceptually a vector already. Don't introduce an extra conversion between it and scalar i64.

I'm using VectorType::isValidElementType which checks for floating point, integer, and pointers to hopefully make this more readable than just blacklisting x86_mmx.

Diff Detail

Event Timeline

craig.topper created this revision.Thu, Nov 7, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 7, 1:18 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
efriedma accepted this revision.Thu, Nov 7, 1:52 PM

LGTM

This revision is now accepted and ready to land.Thu, Nov 7, 1:52 PM
RKSimon accepted this revision.Thu, Nov 7, 2:44 PM

LGTM

This revision was automatically updated to reflect the committed changes.