Page MenuHomePhabricator

[AArch64] Use callee calling convention for RegMask and return value
ClosedPublic

Authored by scw on Nov 6 2019, 1:20 PM.

Details

Reviewers
paquette
echristo
Summary

When lowering calls and tail calls in AArch64, the register mask and
return value location depends on the calling convention of the callee.
F.getCallingConv(), however, is the caller CC. Correct it to the
callee CC from CallLoweringInfo.

Fixes PR43449

Diff Detail

Event Timeline

scw created this revision.Nov 6 2019, 1:20 PM
paquette accepted this revision.Nov 6 2019, 1:33 PM
This revision is now accepted and ready to land.Nov 6 2019, 1:33 PM
scw added a comment.Nov 6 2019, 1:47 PM

Thank you Jessica for the review. I don't have submit permission, could you do it for me? Thank you!

Sure! I just need to get my commit access transferred from SVN to GitHub and then I'll commit it for you.

(Or maybe @echristo can commit it?)

Done thusly:

To github.com:llvm/llvm-project.git

703c97be249..8d694a45ab6  master -> master

Pay attention to the bots as will I :)

scw closed this revision.Nov 6 2019, 3:31 PM

Submitted as llvmorg-10-init-9268-g8d694a45ab6