Page MenuHomePhabricator

[LICM] Hoisting of widenable conditions out of loops
ClosedPublic

Authored by reames on Nov 6 2019, 9:57 AM.

Details

Summary

The change itself is straight forward and obvious, but ... there's an existing test checking for exactly the opposite. I can't identify a reason *why* hoisting of a WC is illegal or undesirable, anyone else see one?

Diff Detail

Event Timeline

reames created this revision.Nov 6 2019, 9:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2019, 9:57 AM
apilipenko accepted this revision.Nov 7 2019, 1:55 PM

Yeah, this limitation seems arbitrary and overly conservative.

This revision is now accepted and ready to land.Nov 7 2019, 1:55 PM
This revision was automatically updated to reflect the committed changes.