This is an archive of the discontinued LLVM Phabricator instance.

Differential D69881

[llvm-readobj] - Simplify elf-hash-symbols.test. NFCI.
ClosedPublic

Authored by grimar on Nov 6 2019, 1:19 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rGc44a9b538d8c: [llvm-readobj] - Simplify elf-hash-symbols.test. NFCI.
Summary

It converts binary contents of .hash and .gnu.hash that were generated by a linker
to YAML descriptions.
I've also dropped Shift2 and BloomFilter values because they are not needed here.

Diff Detail

Event Timeline

grimar created this revision.Nov 6 2019, 1:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2019, 1:19 AM
Herald added subscribers: seiya, rupprecht. · View Herald Transcript
jhenderson accepted this revision.Nov 6 2019, 2:27 AM

LGTM.

This revision is now accepted and ready to land.Nov 6 2019, 2:27 AM
MaskRay accepted this revision.Nov 6 2019, 9:27 AM
Closed by commit rGc44a9b538d8c: [llvm-readobj] - Simplify elf-hash-symbols.test. NFCI. (authored by grimar). · Explain WhyNov 6 2019, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
34 lines

Diff 228183

llvm/test/tools/llvm-readobj/elf-hash-symbols.test

Show All 23 Lines
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS32 Class: ELFCLASS32
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Machine: EM_386 Machine: EM_386
Sections: Sections:
## The contents of .hash and .gnu.hash were generated by a linker.
- Name: .hash - Name: .hash
Type: SHT_HASH Type: SHT_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: '0300000006000000010000000000000000000000000000000500000004000000020000000000000003000000' Bucket: [ 1, 0, 0 ]
Chain: [ 0, 5, 4, 2, 0, 3 ]
- Name: .gnu.hash - Name: .gnu.hash
Type: SHT_GNU_HASH Type: SHT_GNU_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: 0300000002000000010000000500000048991200000000000200000004000000685C880B9169880BF46D880BCB60880B Header:
SymNdx: 0x2
Shift2: 0x0
BloomFilter: [ 0x0 ]
HashBuckets: [ 0x0, 0x2, 0x4 ]
HashValues: [ 0x0B885C68, 0x0B886991, 0x0B886DF4, 0x0B8860CB ]
- Name: .dynamic - Name: .dynamic
Type: SHT_DYNAMIC Type: SHT_DYNAMIC
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
Entries: Entries:
## PT_LOAD's p_vaddr is 0x0. PT_LOAD's p_offset = 0x1bc. DT_HASH value is 0x0. ## PT_LOAD's p_vaddr is 0x0. PT_LOAD's p_offset = 0x1bc. DT_HASH value is 0x0.
## llvm-readelf will read .hash content from p_offset + (p_vaddr - DT_HASH value) = 0x1bc. ## llvm-readelf will read .hash content from p_offset + (p_vaddr - DT_HASH value) = 0x1bc.
## This matches the file offset of the .hash section. ## This matches the file offset of the .hash section.
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
## The contents of .hash and .gnu.hash were generated by a linker.
- Name: .hash - Name: .hash
Type: SHT_HASH Type: SHT_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: '0300000006000000010000000000000000000000000000000500000004000000020000000000000003000000' Bucket: [ 1, 0, 0 ]
Chain: [ 0, 5, 4, 2, 0, 3 ]
- Name: .gnu.hash - Name: .gnu.hash
Type: SHT_GNU_HASH Type: SHT_GNU_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: 030000000200000001000000060000000808020040019200000000000200000004000000685C880B9169880BF46D880BCB60880B Header:
SymNdx: 0x2
Shift2: 0x0
BloomFilter: [ 0x0 ]
HashBuckets: [ 0x00000000, 0x00000002, 0x00000004 ]
HashValues: [ 0x0B885C68, 0x0B886991, 0x0B886DF4, 0x0B8860CB ]
- Name: .dynamic - Name: .dynamic
Type: SHT_DYNAMIC Type: SHT_DYNAMIC
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
Entries: Entries:
- Tag: DT_HASH - Tag: DT_HASH
## PT_LOAD's p_vaddr is 0x0. PT_LOAD's p_offset = 0x2b8. DT_HASH value is 0x0. ## PT_LOAD's p_vaddr is 0x0. PT_LOAD's p_offset = 0x2b8. DT_HASH value is 0x0.
## llvm-readelf will read .hash content from p_offset + (p_vaddr - DT_HASH value) = 0x2b8. ## llvm-readelf will read .hash content from p_offset + (p_vaddr - DT_HASH value) = 0x2b8.
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS32 Class: ELFCLASS32
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Machine: EM_386 Machine: EM_386
Sections: Sections:
## The contents of .hash was generated by a linker.
- Name: .hash - Name: .hash
Type: SHT_HASH Type: SHT_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: '0300000006000000010000000000000000000000000000000500000004000000020000000000000003000000' Bucket: [ 1, 0, 0 ]
Chain: [ 0, 5, 4, 2, 0, 3 ]
- Name: .dynamic - Name: .dynamic
Type: SHT_DYNAMIC Type: SHT_DYNAMIC
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
Entries: Entries:
- Tag: DT_HASH - Tag: DT_HASH
Value: 0x0000000000000000 Value: 0x0000000000000000
- Tag: DT_NULL - Tag: DT_NULL
Show All 39 Lines
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS32 Class: ELFCLASS32
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Machine: EM_386 Machine: EM_386
Sections: Sections:
## The contents of .gnu.hash was generated by a linker.
- Name: .gnu.hash - Name: .gnu.hash
Type: SHT_GNU_HASH Type: SHT_GNU_HASH
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynsym Link: .dynsym
Content: 0300000002000000010000000500000048991200000000000200000004000000685C880B9169880BF46D880BCB60880B Header:
SymNdx: 0x2
Shift2: 0x0
BloomFilter: [ 0x0 ]
HashBuckets: [ 0x0, 0x2, 0x4 ]
HashValues: [ 0x0B885C68, 0x0B886991, 0x0B886DF4, 0x0B8860CB ]
- Name: .dynamic - Name: .dynamic
Type: SHT_DYNAMIC Type: SHT_DYNAMIC
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
Entries: Entries:
- Tag: DT_GNU_HASH - Tag: DT_GNU_HASH
Value: 0x0000000000000000 Value: 0x0000000000000000
- Tag: DT_NULL - Tag: DT_NULL
▲ Show 20 Lines • Show All 141 Lines • Show Last 20 Lines