This is WIP, it doesn't quite work yet. On my dawin machine, I think it is picking up the system libc++abi, rather than the just-built one (maybe I've got the default backwards? not sure).
@danalbert, what do you think? Am I missing anything big?
Paths
| Differential D6985
Merge libc++abi's lit configuration with libc++'s ClosedPublic Authored by jroelofs on Jan 14 2015, 5:03 PM.
Details Summary
@danalbert, what do you think? Am I missing anything big?
Diff Detail Event Timelinejroelofs updated this object. Comment Actions Also, the diff lies... not sure why. It is showing that I deleted all these files, but in fact I've "svn mv"-ed them. Comment Actions Should improve test times significantly, since you seem to have deleted all of them ;) I'm assuming you renamed them with .pass.cpp and forgot to add the new names (git mv is your friend). As I said in IRC, I don't really like building metadata in to the test name. I'd rather see // XCOMPILE-FAIL or similar added to the test runner instead. Looks much better. I'm especially liking all the red. I'll try cherry-picking this tomorrow to see if it meets all my needs, but it looks like it should.
Comment Actions I svn mv'd all the files to their *.pass.cpp equivalents. Not sure why they aren't showing up in the diff. I could go either way on the metadata thing. Or do both, and have checks that the extension matches the metadata. Don't really have a preference.
jroelofs edited edge metadata. Comment ActionsAddress most of @danalbert's comments. I'm still not sure what I'm doing wrong with the library paths.... this still breaks tests on darwin.
danalbert edited subscribers, added: Unknown Object (MLST); removed: danalbert.Jan 15 2015, 10:25 AM Comment ActionsPinging in the hope that it will reach cfe-commits. Comment Actions Fix up the library path stuff. This at least works on darwin now. Haven't checked on linux yet. Comment Actions I can't patch CMakeLists.txt completely, Can you make sure that you diffed against the trunk? Comment Actions I suspect that's because of @danalbert's recent cmake changes for cross compiling... lame. jroelofs updated this object. jroelofs edited edge metadata. Comment ActionsRebase, and add detection/configuration bits that make the libcxx imports work. Symlinking test/libcxx is no longer necessary. Tests work on darwin now. Still haven't checked on linux.
Comment Actions I could have merged that either way, actually. I wasn't sure which one was more preferable. danalbert edited edge metadata. Comment ActionsReusing the LLVM cmake code is preferred. Once that is fixed up, LGTM. This revision is now accepted and ready to land.Jan 21 2015, 3:01 PM
Revision Contents
Diff 18232 CMakeLists.txt
libcxxabi/test/config.py
lit.cfg
lit.site.cfg.in
|
Diffs in this file bring libc++abi's version of this file most of the way in sync with libc++'s. I'm not too familiar with cmake to know whether 'add_custom_target' vs 'add_lit_testsuite' is better here. I suspect the change should be going the other way?