Page MenuHomePhabricator

[TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (Baseline)
ClosedPublic

Authored by joanlluch on Oct 30 2019, 1:40 AM.

Details

Summary

This revision is the baseline tests for D69120, so it's intended to be committed before it.
The only purpose is to show and clarify the effects of applying D69120.
This revision updates 'shift-amount-threshold.ll' with improved test cases for D69120

Diff Detail

Event Timeline

joanlluch created this revision.Oct 30 2019, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2019, 1:40 AM
spatel accepted this revision.Oct 30 2019, 6:40 AM

LGTM - have you requested/acquired commit privilege yet?

This revision is now accepted and ready to land.Oct 30 2019, 6:40 AM
spatel added inline comments.Oct 30 2019, 6:41 AM
llvm/test/CodeGen/MSP430/shift-amount-threshold.ll
147

Test name got garbled.

joanlluch marked an inline comment as done.Oct 30 2019, 9:11 AM
joanlluch added inline comments.
llvm/test/CodeGen/MSP430/shift-amount-threshold.ll
147

Hi @spatel, I'm not English native, don't know what "garbled" means in this context. Please can you elaborate?. Is there something I need to do?.
I changed the name of this test case compared with my previous commit to match the LLVM function that is responsible for the transformation. Thanks

LGTM - have you requested/acquired commit privilege yet?

No, I don't have or requested it. I don't really plan to become a long term contributor of LLVM patches, so I'm unsure if I actually need it. I'm happy by posting my proposals and allow regular members to review and commit the changes.

LGTM - have you requested/acquired commit privilege yet?

No, I don't have or requested it. I don't really plan to become a long term contributor of LLVM patches, so I'm unsure if I actually need it. I'm happy by posting my proposals and allow regular members to review and commit the changes.

At this point, you have had at least 3 patches accepted, so you should request that permission. It is more work for me to commit for you, and it is slower for you.

llvm/test/CodeGen/MSP430/shift-amount-threshold.ll
147

I meant the spelling was wrong:
testSiymplifySelectCC_1 --> testSimplifySelectCC_1

joanlluch marked an inline comment as done.Oct 30 2019, 11:11 AM
joanlluch added inline comments.
llvm/test/CodeGen/MSP430/shift-amount-threshold.ll
147

Oh well, there's another test above with the wrong spelling as well. Will get those corrected on my next patch.

joanlluch marked an inline comment as not done.Oct 30 2019, 11:12 AM
asl accepted this revision.Oct 30 2019, 11:22 AM

In general LGTM. But will you please correct the test names, so I can commit on your behalf?

Thanks!

spatel closed this revision.Oct 30 2019, 11:24 AM

I just pushed this to trunk, but I forgot to include this review number:
rG67da730da636
rG3e8557143251