This is an archive of the discontinued LLVM Phabricator instance.

Differential D69568

Remove unnecessary unit test dependencies.
ClosedPublic

Authored by hjyamauchi on Oct 29 2019, 9:28 AM.

Details

Reviewers
davidxl
thakis
Commits
rG3a399c098782: Remove unnecessary unit test dependencies.
Summary

This is to address comment on D69409.

Diff Detail

Event Timeline

hjyamauchi created this revision.Oct 29 2019, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2019, 9:28 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B40199: Diff 226914.Oct 29 2019, 9:29 AM
hjyamauchi mentioned this in D69409: [PGO][PGSO] SizeOpts changes..Oct 29 2019, 9:30 AM
thakis accepted this revision.Nov 1 2019, 5:51 AM

Thanks!

This revision is now accepted and ready to land.Nov 1 2019, 5:51 AM
Closed by commit rG3a399c098782: Remove unnecessary unit test dependencies. (authored by hjyamauchi). · Explain WhyNov 1 2019, 9:32 AM
This revision was automatically updated to reflect the committed changes.
MaskRay mentioned this in rGadd76dd3cbeb: [X86] Fix -DBUILD_SHARED_LIBS=on builds after D69568/llvmorg-10-init-8877….Nov 1 2019, 9:59 AM

Revision Contents

PathSize
llvm/
unittests/
Target/
X86/
4 lines

Diff 227468

llvm/unittests/Target/X86/CMakeLists.txt

include_directories( include_directories(
${CMAKE_SOURCE_DIR}/lib/Target/X86 ${CMAKE_SOURCE_DIR}/lib/Target/X86
${CMAKE_BINARY_DIR}/lib/Target/X86 ${CMAKE_BINARY_DIR}/lib/Target/X86
) )
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Analysis Analysis
CodeGen CodeGen
Core
GlobalISel
MC
MIRParser MIRParser
SelectionDAG
Support Support
Target Target
X86CodeGen X86CodeGen
X86Desc X86Desc
X86Info X86Info
) )
add_llvm_unittest(X86Tests add_llvm_unittest(X86Tests
MachineSizeOptsTest.cpp MachineSizeOptsTest.cpp
) )