This is an archive of the discontinued LLVM Phabricator instance.

Differential D69544

[clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method
ClosedPublic

Authored by arphaman on Oct 28 2019, 6:31 PM.

Details

Reviewers
ilya-biryukov
Commits
rGe1b07aac3d1c: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply…

Diff Detail

Event Timeline

arphaman created this revision.Oct 28 2019, 6:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2019, 6:31 PM
Herald added subscribers: usaxena95, ributzka, kadircet and 3 others. · View Herald Transcript
ilya-biryukov accepted this revision.Oct 29 2019, 2:34 AM

LGTM

This revision is now accepted and ready to land.Oct 29 2019, 2:34 AM
Closed by commit rGe1b07aac3d1c: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply… (authored by arphaman). · Explain WhyNov 8 2019, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
clangd/
refactor/
tweaks/
3 lines

Diff 228524

clang-tools-extra/clangd/refactor/tweaks/RawStringLiteral.cpp

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Linesbool RawStringLiteral::prepare(const Selection &Inputs) {
return Str && return Str &&
isNormalString(*Str, Inputs.Cursor, Inputs.AST.getSourceManager()) && isNormalString(*Str, Inputs.Cursor, Inputs.AST.getSourceManager()) &&
needsRaw(Str->getBytes()) && canBeRaw(Str->getBytes()); needsRaw(Str->getBytes()) && canBeRaw(Str->getBytes());
} }
Expected<Tweak::Effect> RawStringLiteral::apply(const Selection &Inputs) { Expected<Tweak::Effect> RawStringLiteral::apply(const Selection &Inputs) {
auto &SM = Inputs.AST.getSourceManager(); auto &SM = Inputs.AST.getSourceManager();
auto Reps = tooling::Replacements( auto Reps = tooling::Replacements(
tooling::Replacement(Inputs.AST.getSourceManager(), Str, tooling::Replacement(SM, Str, ("R\"(" + Str->getBytes() + ")\"").str(),
("R\"(" + Str->getBytes() + ")\"").str(),
Inputs.AST.getASTContext().getLangOpts())); Inputs.AST.getASTContext().getLangOpts()));
return Effect::mainFileEdit(SM, std::move(Reps)); return Effect::mainFileEdit(SM, std::move(Reps));
} }
} // namespace } // namespace
} // namespace clangd } // namespace clangd
} // namespace clang } // namespace clang