This is an archive of the discontinued LLVM Phabricator instance.

OpenMP: Add helper function for convergent runtime calls
ClosedPublic

Authored by arsenm on Oct 27 2019, 6:08 PM.

Details

Summary

Most of the functions emitted here should probably be convergent, but
only barriers are currently marked. Introduce this helper before
adding convergent to more functions.

Diff Detail

Event Timeline

arsenm created this revision.Oct 27 2019, 6:08 PM
JonChesterfield accepted this revision.Oct 27 2019, 6:13 PM
JonChesterfield added a reviewer: grokos.

LGTM.

This revision is now accepted and ready to land.Oct 27 2019, 6:13 PM
ABataev requested changes to this revision.Oct 27 2019, 6:38 PM

Tests?

clang/lib/CodeGen/CodeGenModule.h
1039

Add a comment with the name of parameter for true argument.

This revision now requires changes to proceed.Oct 27 2019, 6:38 PM
arsenm updated this revision to Diff 226610.Oct 27 2019, 7:10 PM

Add comments

Tests?

Tests?

This is NFC and doesn't change any behavior. The test for the convergent attribute is already handled in nvptx_parallel_codegen.cpp

Tests?

Tests?

This is NFC and doesn't change any behavior. The test for the convergent attribute is already handled in nvptx_parallel_codegen.cpp

Nope, you're narking some calls withe the new attribute. It is not NFC in this case.

Tests?

Tests?

This is NFC and doesn't change any behavior. The test for the convergent attribute is already handled in nvptx_parallel_codegen.cpp

Nope, you're narking some calls withe the new attribute. It is not NFC in this case.

More precisely, this is marking the function declarations with the attribute. These were already marked with the attribute. This just moves it into the helper function. D69495 adds new instances of the attribute

ABataev accepted this revision.Oct 27 2019, 7:31 PM

Ah, yes, missed this. Then just add a comment.

This revision is now accepted and ready to land.Oct 27 2019, 7:31 PM
arsenm closed this revision.Oct 27 2019, 9:27 PM

r40ab8ae9fb70f1550815bf0f867148b5101a4f66