[lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'

[wallace]

Supposedly Arguments shouldn't contain Arg0 (https://reviews.llvm.org/source/llvm-github/browse/master/lldb/include/lldb/Utility/ProcessInfo.h$96)
I think you just need to change the dump method that prints to platform process list.

I don't know if NetBSD is doing something different, but the general dump method for ProcessInfo prints first arg0 and then the other args https://reviews.llvm.org/source/llvm-github/browse/master/lldb/source/Utility/ProcessInfo.cpp$229-235

[mgorny]

Hmm, I think I see how it's supposed to work. I'm going to update the patch after I test it.

[mgorny]

Ok, how does that look instead? ;-)

[wallace]

cool! thanks!!

lldb/source/Host/netbsd/Host.cpp

static bool GetNetBSDProcessArgs(const ProcessInstanceInfoMatch *match_info_ptr,
 
   if (!(match_info_ptr == NULL ||
         NameMatches(process_info.GetExecutableFile().GetFilename().GetCString(),
                     match_info_ptr->GetNameMatchType(),
                     match_info_ptr->GetProcessInfo().GetName())))
     return false;
 
   Args &proc_args = process_info.GetArguments();
+  proc_args.AppendArgument(llvm::StringRef(cstr));
   while (1) {
     const uint8_t *p = data.PeekData(offset, 1);
     while ((p != NULL) && (*p == '\0') && offset < arg_data_size) {
       ++offset;
       p = data.PeekData(offset, 1);
     }
     if (p == NULL || offset >= arg_data_size)
       break;