The virtual container/header section caused the section list to be offset by one, but by using FindSectionByID, the layout of the section list shouldn't matter.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp | ||
---|---|---|
691 | You should use FindSectionByID here. That's the API used by both ELF and MachO object files and SymbolFilePDB classes for this sort of thing. This would obviate the need for the long comment and make this patch independent of the header stuff (which I'm going to commit as soon as I figure out how that's done). | |
lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml | ||
3 | At some point we'll probably want to add some kind of a symtab dumping mechanism to the object-file subcommand, but this is fine until then. | |
5 | Could you also add a CHECK line with the table header, just so one gets the idea of what is the meaning of individual fields.. |
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp | ||
---|---|---|
691 | +1 to labath's suggestion. It seems unfortunate that this already had a coupling to implementation details of the section list. |
You should use FindSectionByID here. That's the API used by both ELF and MachO object files and SymbolFilePDB classes for this sort of thing. This would obviate the need for the long comment and make this patch independent of the header stuff (which I'm going to commit as soon as I figure out how that's done).