Page MenuHomePhabricator

[test] Add a .clang-format file for the shell test.
ClosedPublic

Authored by JDevlieghere on Oct 16 2019, 11:00 AM.

Details

Summary

The API tests have a .clang-format file that disables formatting altogether. While this is needed for some tests, it also leads to inconsistency between test files. The shell tests suffer from a similar problem: a test with a source-file extension (.c, .cpp) will get formatted, potentially breaking up lines and leading to invalid RUN commands. Rather than completely disabling formatting here, I propose to not enforce a line limit instead. That way tests will be consistent, but you can still have long run commands (as is not uncommon in LLVM either) and use breakpoints with patters that extend beyond 80 cols.

Diff Detail

Event Timeline

JDevlieghere created this revision.Oct 16 2019, 11:00 AM
teemperor accepted this revision.Oct 17 2019, 1:08 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 17 2019, 1:08 PM
This revision was automatically updated to reflect the committed changes.