This is an archive of the discontinued LLVM Phabricator instance.

change shortcut for 'step out' from 'o' to 'f'
ClosedPublic

Authored by llunak on Oct 12 2019, 4:42 AM.

Details

Summary

This makes it consistent with gdb tui, where 'f' is 'finish'.
See the discussion at https://reviews.llvm.org/D68541 .

Diff Detail

Repository
rLLDB LLDB

Event Timeline

llunak created this revision.Oct 12 2019, 4:42 AM
kwk added a subscriber: kwk.Nov 7 2019, 5:28 AM

Are there no tests for this code?

llunak added a comment.Nov 7 2019, 6:59 AM
In D68909#1736931, @kwk wrote:

Are there no tests for this code?

https://reviews.llvm.org/D68541 adds one that also covers this.

clayborg accepted this revision.Jul 25 2020, 3:48 PM
This revision is now accepted and ready to land.Jul 25 2020, 3:48 PM
llunak updated this revision to Diff 281707.Jul 29 2020, 12:40 PM

Updated for current git.

clayborg accepted this revision.Jul 29 2020, 1:00 PM
This revision was automatically updated to reflect the committed changes.