[LNT] NFC: Fix order of globals and locals on exec

[hubert.reinterpretcast]

Summary

Per https://docs.python.org/3/library/functions.html#exec, the globals parameter comes before the locals one. Since globals and locals refer to the same object for the call in question, we can remove locals, which will cause the globals parameter to be used for both the global and the local variables, thus keeping the same behavior.

[thopre]

LGTM but would suggest this altered description:

Per https://docs.python.org/3/library/functions.html#exec, globals parameter comes before locals. Since globals and locals refer to the same object for the call in question, we can remove locals, which will make globals used for both the global and the local variables, thus keeping the same behavior.

[hubert.reinterpretcast]

Committed: https://github.com/llvm/llvm-lnt/commit/f805c3e1eece29e502a88a095c710f32473ca3c5

lnt/tests/nt.py

def execute_test_modules(test_log, test_modules, test_module_variables,
     # For now, we don't execute these in parallel, but we do forward the
     # parallel build options to the test.
     test_modules.sort()
 
     print('%s: executing test modules' % (timestamp(), ), file=sys.stderr)
     results = []
     for name in test_modules:
         # First, load the test module file.
-        locals = globals = {}
+        globals = {}
         test_path = os.path.join(config.test_suite_root, 'LNTBased', name)
         # This is where shared code between test modules should go.
         sys.path.append(os.path.join(config.test_suite_root, 'LNTBased/lib'))
         test_obj_path = os.path.join(basedir, 'LNTBased', name)
         module_path = os.path.join(test_path, 'TestModule')
         module_file = open(module_path)
         try:
-            exec(module_file, locals, globals)
+            exec(module_file, globals)
         except Exception:
             info = traceback.format_exc()
             fatal("unable to import test module: %r\n%s" % (
                     module_path, info))
 
         # Lookup and instantiate the test class.
         test_class = globals.get('test_class')
         if test_class is None: