Page MenuHomePhabricator

[LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows
ClosedPublic

Authored by mstorsjo on Oct 11 2019, 3:47 AM.

Details

Summary

This should allow lldb-server to operate on files with non-ascii pathnames.

I tried looking around in lldb/tools, and this seemed like the only other tool (other than the main lldb driver itself) that would be used (implicitly) by an end user (which could be working in non-ascii paths).

This does the same as for D68770 (where the main driver earlier was using custom code in the driver to convert unicode to utf8), while lldb-server didn't have any unicode handling at all before (where the main arguments would be given in the native local codepage, while the rest of llvm internals expect utf8).

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 11 2019, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2019, 3:47 AM
labath accepted this revision.Oct 11 2019, 3:57 AM
This revision is now accepted and ready to land.Oct 11 2019, 3:57 AM
aleksandr.urakov accepted this revision.Oct 11 2019, 4:15 AM
This revision was automatically updated to reflect the committed changes.