Page MenuHomePhabricator
Differential D68756

[libc++][test] Change IsSmallObject's calculation for std::any's small object buffer
ClosedPublic
Actions

Authored by CaseyCarter on Oct 9 2019, 6:49 PM.

Details

Reviewers
mclow.lists
EricWF
ldionne
Commits
rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object…
rCXX374407: [libc++][test] Change IsSmallObject's calculation for std::any's small object…
rL374407: [libc++][test] Change IsSmallObject's calculation for std::any's small object…
Summary

sizeof(std::any) - sizeof(void*) is correct for both libc++ and the MSVC standard library.

Diff Detail

Event Timeline

CaseyCarter created this revision.Oct 9 2019, 6:49 PM
Herald added subscribers: libcxx-commits, dexonsmith, christof. · View Herald TranscriptOct 9 2019, 6:49 PM
CaseyCarter marked an inline comment as done.Oct 9 2019, 6:51 PM
CaseyCarter added inline comments.
libcxx/test/support/any_helpers.h
29

I have no idea why this line is highlighted: there are no changes on this line in the diff I submitted, the line endings are plain LF, ... :shrug:

EricWF accepted this revision.Oct 10 2019, 1:39 AM
EricWF added inline comments.
libcxx/test/support/any_helpers.h
36

LGTM.

This revision is now accepted and ready to land.Oct 10 2019, 1:39 AM
Closed by commit rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object… (authored by CaseyCarter). · Explain WhyOct 10 2019, 11:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
libcxx/
test/
support/
2 lines

Diff 224422

View Options

libcxx/test/support/any_helpers.h

Loading...