Page MenuHomePhabricator

[ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.
ClosedPublic

Authored by efriedma on Oct 9 2019, 4:39 PM.

Details

Summary

Just running -fsyntax-only over arm_neon.h doesn't cover some intrinsics which are defined using macros. Add more test coverage for that.

arm-neon-header.c wasn't checking the full set of available NEON target features; change the target architecture to account for that.

We were not generating necessary casts in some cases; add test coverage for that.

Fix VFMLAL_LOW etc. to express their signatures differently, so the builtins have the expected type. Maybe the TableGen backend should detect this and produce an error. The rules here are sort of strange.

Diff Detail

Repository
rC Clang

Event Timeline

efriedma created this revision.Oct 9 2019, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2019, 4:39 PM
efriedma updated this revision to Diff 224229.Oct 9 2019, 6:30 PM
efriedma edited the summary of this revision. (Show Details)

Found another broken case. Fix, and add more test coverage.

SjoerdMeijer accepted this revision.Oct 10 2019, 12:39 AM

Thanks again, looks good.

This revision is now accepted and ready to land.Oct 10 2019, 12:39 AM
This revision was automatically updated to reflect the committed changes.