This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Ensure that ExecutableFunction are aligned.
ClosedPublic

Authored by courbet on Oct 9 2019, 6:28 AM.

Details

Summary

Experiments show that this is the alignment we get (for ELF+Linux), but let's ensure that we have it.

Event Timeline

courbet created this revision.Oct 9 2019, 6:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2019, 6:28 AM
Herald added a subscriber: tschuett. · View Herald Transcript
gchatelet added inline comments.Oct 9 2019, 6:42 AM
llvm/tools/llvm-exegesis/lib/Assembler.cpp
311

assert(isAligned(FunctionAddress, kFunctionAlignment) && "function is not properly aligned");

courbet updated this revision to Diff 224043.Oct 9 2019, 6:49 AM
courbet marked an inline comment as done.

Address Comments

courbet updated this revision to Diff 224047.Oct 9 2019, 7:07 AM

make type explicit

gchatelet accepted this revision.Oct 9 2019, 7:08 AM
This revision is now accepted and ready to land.Oct 9 2019, 7:08 AM
This revision was automatically updated to reflect the committed changes.