This is an archive of the discontinued LLVM Phabricator instance.

[clang-offload-bundler] Support `.cui` and `.d`.
ClosedPublic

Authored by hliao on Oct 8 2019, 1:22 PM.

Diff Detail

Event Timeline

hliao created this revision.Oct 8 2019, 1:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 1:22 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hliao added a comment.Oct 8 2019, 1:26 PM

Adding this support is aimed to prevent crashing or failure, it's not intended to be final output for -M or -E. So, hip fails on these options due to the unsupported type of clang-offload-bundler. Before we nail down the details on the expected output of -M or -E, especially -M, we at least should not fail them.

tra accepted this revision.Oct 8 2019, 1:59 PM
This revision is now accepted and ready to land.Oct 8 2019, 1:59 PM
tra added a comment.Oct 8 2019, 2:01 PM

Maybe, add a TODO to eventually remove .d .
.cui should probably remain as it's yet another variant of preprocessed output that we allow bundling for C/C++.

This revision was automatically updated to reflect the committed changes.