This is an archive of the discontinued LLVM Phabricator instance.

[libTooling] Move Transformer files to their own directory/library.
ClosedPublic

Authored by ymandel on Oct 8 2019, 6:27 AM.

Details

Summary

The Transformer library has been growing inside of lib/Tooling/Refactoring. However, it's not really related to anything else in that directory. This revision moves all Transformer-related files into their own include & lib directories. A followup revision will (temporarily) add forwarding headers to help any users migrate their code to the new location.

Diff Detail

Event Timeline

ymandel created this revision.Oct 8 2019, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 6:27 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ymandel edited the summary of this revision. (Show Details)Oct 8 2019, 6:38 AM
ymandel edited the summary of this revision. (Show Details)
gribozavr accepted this revision.Oct 8 2019, 6:41 AM

Update header guards?

This revision is now accepted and ready to land.Oct 8 2019, 6:41 AM
ymandel updated this revision to Diff 223840.Oct 8 2019, 6:46 AM

update header guards

ymandel updated this revision to Diff 223856.Oct 8 2019, 7:33 AM

update another cmakelists file (uncovered by linking for shared libs)

This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Oct 9 2019, 7:38 PM
thakis added inline comments.
clang/lib/Tooling/Transformer/CMakeLists.txt
3

All the other libs in lib/Tooling/Foo are called clangToolingFoo, not clangFoo. Can you please rename this library to clangToolingTransformer?

ymandel marked 2 inline comments as done.Oct 9 2019, 8:24 PM
ymandel added inline comments.
clang/lib/Tooling/Transformer/CMakeLists.txt
3

Not all:
https://reviews.llvm.org/source/llvm-github/browse/master/clang/lib/Tooling/DependencyScanning/CMakeLists.txt

I checked this before. :) Is there a reason that you want that naming scheme or just for consistency? I think that clangTransformer is a better name for the library, but I don't care much. I just noticed we didn't seem to be consistent anyhow, so went w/ my (slight) preference.