[LLDB] Remove standalone build dep on llvm-strip

[gmittert]

Summary

When building standalone, since llvm-strip is a symlink, it is created
using add_custom_command/add_custom_target which cannot be exported, and
thus cannot be depended on by lldb.

[xiaobai]

@JDevlieghere has been touching similar things today. You should coordinate with him on this change.

lit/CMakeLists.txt

64 ↗

(On Diff #223703)

why not if(TARGET llvm-strip)? I think that expresses the intent more cleanly (and conforms to the existing pattern).

[JDevlieghere]

lit/CMakeLists.txt

64 ↗

(On Diff #223703)

I actually ran into an issue with that today, we had the following code in the top-level CMake list:

if(TARGET dsymutil)
    add_lldb_test_dependency(dsymutil)
  endif()

Nevertheless, ninja lldb-test-deps didn't build dsymutil.

$ /V/J/l/build-ra> ninja lldb-test-deps
[1/1] Python script sym-linking LLDB Python API
$ /V/J/l/build-ra> ninja dsymutil
[1/1] Linking CXX executable bin/dsymutil

[kwk]

I think I'm guilty for adding llvm-strip to LLDB_TEST_DEPS I wasn't aware that it might cause problems.

[compnerd]

lit/CMakeLists.txt

64 ↗

(On Diff #223703)

My slight preference for this is to actually have a good way to identify that this can be simplified once unified builds are the only supported build style. I suppose a comment along with the if(TARGET) check would work too.

[gmittert]

Alright, rebased and added a comment to it

[xiaobai]

LGTM

[gmittert]

Thanks! Can someone commit this for me?

[gmittert]

Updated/Rebased for the rename of lit->test

lldb/test/CMakeLists.txt

add_lldb_test_dependency(
   llc
   lli
   llvm-config
   llvm-dwarfdump
   llvm-nm
   llvm-mc
   llvm-objcopy
   llvm-readobj
-  llvm-strip
   )
 
+# Since llvm-strip is a symlink created by add_custom_target, it
+# doesn't expose an export target when building standalone.
+if(NOT LLDB_BUILT_STANDALONE)
+  add_lldb_test_dependency(llvm-strip)
+endif()
+
 if(TARGET lld)
   add_lldb_test_dependency(lld)
 else()
   # LLD is required to link test executables on Windows.
   if (CMAKE_SYSTEM_NAME MATCHES "Windows")
     message(WARNING "lld required to test LLDB on Windows")
   endif()
 endif()