This change is mostly performance-neutral since our regex engine is fast, but it's IMHO slightly more readable.
Also, matching matching parenthesis is not a great match for regular expressions.
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D68609
Replace regex match with rfind (NFCish) ClosedPublic Authored by aprantl on Oct 7 2019, 4:48 PM.
Details Summary This change is mostly performance-neutral since our regex engine is fast, but it's IMHO slightly more readable.
Diff Detail Event TimelineThis revision is now accepted and ready to land.Oct 7 2019, 5:15 PM Closed by commit rGea6377505435: Replace regex match with rfind (NFCish) (authored by aprantl). · Explain WhyOct 8 2019, 9:35 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 223695 lldb/include/lldb/Symbol/ObjectFile.h
lldb/source/Symbol/ObjectFile.cpp
|
now that this is self-resizing, this can probably be something smaller (PATH_MAX on windows is 32k, sort of)..