This is an archive of the discontinued LLVM Phabricator instance.

[IA] Recognize hexadecimal escape sequences
ClosedPublic

Authored by void on Oct 7 2019, 2:48 PM.

Details

Summary

Implement support for hexadecimal escape sequences to match how GNU 'as'
handles them. I.e., read all hexadecimal characters and truncate to the
lower 16 bits.

Event Timeline

void created this revision.Oct 7 2019, 2:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2019, 10:27 PM
This revision was automatically updated to reflect the committed changes.
jcai19 added inline comments.Oct 7 2019, 11:55 PM
llvm/test/MC/AsmParser/directive_ascii.s
46

Thanks for the update. Could we have one more test case with last eight bits within the range of 7f and ff, and maybe with lower-case letter, e.g. \x8a?

jcai19 added inline comments.Oct 8 2019, 4:02 PM
llvm/test/MC/AsmParser/directive_ascii.s
46

Test cases added at r374124.