Page MenuHomePhabricator

[lit] Remove setting of the target-windows feature
ClosedPublic

Authored by mstorsjo on Oct 4 2019, 12:38 AM.

Details

Summary

No other OSes use a target-<os> feature, and no tests (rightfully) depend on it. (This depends on D68449 to land before.)

This is an alternative to D68135. (The diff is made on top of it for practical reasons.)

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 4 2019, 12:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 12:38 AM
Herald added a subscriber: delcypher. · View Herald Transcript

Ping @rnk - we should either go with this, or D68135.

rnk accepted this revision.Oct 11 2019, 1:32 PM

lgtm

This revision is now accepted and ready to land.Oct 11 2019, 1:32 PM
This revision was automatically updated to reflect the committed changes.