This is an archive of the discontinued LLVM Phabricator instance.

Differential D68449

[test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC.
ClosedPublic

Authored by mstorsjo on Oct 4 2019, 12:35 AM.

Details

Reviewers
rnk
Commits
rG174604c93cad: [test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC.
rL373780: [test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC.
Summary

Posting this one separately, as I had to revert D68133.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Oct 4 2019, 12:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 12:35 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
mstorsjo added a child revision: D68450: [lit] Remove setting of the target-windows feature.Oct 4 2019, 12:38 AM
rnk accepted this revision.Oct 4 2019, 11:36 AM

lgtm

This revision is now accepted and ready to land.Oct 4 2019, 11:36 AM
mstorsjo mentioned this in D68135: [lit] Set the target-windows feature for any windows environment.Oct 4 2019, 12:20 PM
Closed by commit rL373780: [test] Remove another two unnecessary uses of REQUIRES: target-windows. NFC. (authored by mstorsjo). · Explain WhyOct 4 2019, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
tools/
llvm-symbolizer/
2 lines
2 lines

Diff 223266

llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test

RUN: llvm-symbolizer 0x5009 0x5038 --inlining --relative-address -obj="%p/Inputs/coff-dwarf.exe" \ RUN: llvm-symbolizer 0x5009 0x5038 --inlining --relative-address -obj="%p/Inputs/coff-dwarf.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
RUN: llvm-symbolizer 0x5009 0x5038 --inlines --relative-address -obj="%p/Inputs/coff-dwarf.exe" \ RUN: llvm-symbolizer 0x5009 0x5038 --inlines --relative-address -obj="%p/Inputs/coff-dwarf.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
RUN: llvm-symbolizer 0x5009 0x5038 -i --relative-address -obj="%p/Inputs/coff-dwarf.exe" \ RUN: llvm-symbolizer 0x5009 0x5038 -i --relative-address -obj="%p/Inputs/coff-dwarf.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
This test relies on UnDecorateSymbolName, which is Windows-only. This test relies on UnDecorateSymbolName, which is Windows-only.
REQUIRES: target-windows, system-windows REQUIRES: system-windows
CHECK: foo(void) CHECK: foo(void)
CHECK: coff-dwarf.cpp:7 CHECK: coff-dwarf.cpp:7
CHECK: bar(void) CHECK: bar(void)
CHECK: coff-dwarf.cpp:13 CHECK: coff-dwarf.cpp:13
CHECK: main CHECK: main
CHECK: coff-dwarf.cpp:17 CHECK: coff-dwarf.cpp:17

llvm/trunk/test/tools/llvm-symbolizer/coff-exports.test

RUN: llvm-symbolizer 0x500A 0x5038 0x504B --inlining --relative-address -obj="%p/Inputs/coff-exports.exe" \ RUN: llvm-symbolizer 0x500A 0x5038 0x504B --inlining --relative-address -obj="%p/Inputs/coff-exports.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
RUN: llvm-symbolizer 0x500A 0x5038 0x504B --inlines --relative-address -obj="%p/Inputs/coff-exports.exe" \ RUN: llvm-symbolizer 0x500A 0x5038 0x504B --inlines --relative-address -obj="%p/Inputs/coff-exports.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
RUN: llvm-symbolizer 0x500A 0x5038 0x504B -i --relative-address -obj="%p/Inputs/coff-exports.exe" \ RUN: llvm-symbolizer 0x500A 0x5038 0x504B -i --relative-address -obj="%p/Inputs/coff-exports.exe" \
RUN: | FileCheck %s RUN: | FileCheck %s
This test relies on UnDecorateSymbolName, which is Win32-only. This test relies on UnDecorateSymbolName, which is Win32-only.
REQUIRES: system-windows REQUIRES: system-windows
REQUIRES: target-windows
FIXME: This test depends on host, not target.
We get the expected stack trace, except 'foo' appears for the 'bar' frame We get the expected stack trace, except 'foo' appears for the 'bar' frame
because 'bar' isn't in the export table. because 'bar' isn't in the export table.
CHECK: foo(void) CHECK: foo(void)
CHECK: ??:0:0 CHECK: ??:0:0
CHECK: foo(void) CHECK: foo(void)
CHECK: ??:0:0 CHECK: ??:0:0
CHECK: main CHECK: main
CHECK: ??:0:0 CHECK: ??:0:0