[clang-rename] Better renaming the typedef decl.

[hokein]

Summary

when renaming a typedef decl, we used to rename the underlying decl of the
typedef, we should rename the typedef itself.

cfe/trunk/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h

if (const auto *TemplateTypeParm =
         return false;
     }
     if (const auto *TemplateSpecType =
             dyn_cast<TemplateSpecializationType>(Loc.getType())) {
       if (!visit(TemplateSpecType->getTemplateName().getAsTemplateDecl(),
                  TypeBeginLoc, TypeEndLoc))
         return false;
     }
-    return visit(Loc.getType()->getAsCXXRecordDecl(), TypeBeginLoc, TypeEndLoc);
+    if (const Type *TP = Loc.getTypePtr()) {
+      if (TP->getTypeClass() == clang::Type::Record)
+        return visit(TP->getAsCXXRecordDecl(), TypeBeginLoc, TypeEndLoc);
+    }
+    return true;
+  }
+
+  bool VisitTypedefTypeLoc(TypedefTypeLoc TL) {
+    const SourceLocation TypeEndLoc =
+        Lexer::getLocForEndOfToken(TL.getBeginLoc(), 0, SM, LangOpts);
+    return visit(TL.getTypedefNameDecl(), TL.getBeginLoc(), TypeEndLoc);
   }
 
   bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
     // The base visitor will visit NNSL prefixes, so we should only look at
     // the current NNS.
     if (NNS) {
       const NamespaceDecl *ND = NNS.getNestedNameSpecifier()->getAsNamespace();
       if (!visit(ND, NNS.getLocalBeginLoc(), NNS.getLocalEndLoc()))

cfe/trunk/test/clang-rename/Typedef.cpp

+namespace std {
+class basic_string {};
+typedef basic_string string;
+} // namespace std
+
+std::string foo(); //  // CHECK: std::new_string foo();
+
+// RUN: clang-rename -offset=93 -new-name=new_string %s --  | sed 's,//.*,,' | FileCheck %s