This is an archive of the discontinued LLVM Phabricator instance.

Differential D68295

[libcxx] [test] Use host system separators when setting PATH in config.py
AbandonedPublic

Authored by broadwaylamb on Oct 1 2019, 1:57 PM.

Details

Reviewers
EricWF

Diff Detail

Event Timeline

broadwaylamb created this revision.Oct 1 2019, 1:57 PM
Herald added a reviewer: EricWF. · View Herald TranscriptOct 1 2019, 1:57 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, ldionne, christof. · View Herald Transcript
Harbormaster completed remote builds in B38850: Diff 222697.Oct 1 2019, 1:57 PM
broadwaylamb updated this revision to Diff 222698.Oct 1 2019, 2:00 PM

Use host system separators when setting PATH in config.py

broadwaylamb abandoned this revision.Oct 1 2019, 2:01 PM
Harbormaster completed remote builds in B38851: Diff 222698.Oct 1 2019, 2:02 PM

Revision Contents

PathSize
libcxx/
utils/
libcxx/
test/
2 lines

Diff 222697

libcxx/utils/libcxx/test/config.py

Show First 20 Lines • Show All 1,199 Lines • ▼ Show 20 Lines
def configure_env(self): def configure_env(self):
self.target_info.configure_env(self.exec_env) self.target_info.configure_env(self.exec_env)
def add_path(self, dest_env, new_path): def add_path(self, dest_env, new_path):
if 'PATH' not in dest_env: if 'PATH' not in dest_env:
dest_env['PATH'] = new_path dest_env['PATH'] = new_path
else: else:
split_char = ';' if self.target_info.is_windows() else ':' split_char = ';' if platform.system() == 'Windows' else ':'
dest_env['PATH'] = '%s%s%s' % (new_path, split_char, dest_env['PATH'] = '%s%s%s' % (new_path, split_char,
dest_env['PATH']) dest_env['PATH'])