Page MenuHomePhabricator

[JSON] Use LLVM's library for decoding JSON in StructuredData
ClosedPublic

Authored by JDevlieghere on Oct 1 2019, 10:10 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Oct 1 2019, 10:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 10:10 AM
aprantl added inline comments.Oct 1 2019, 10:18 AM
lldb/source/Utility/StructuredData.cpp
48 ↗(On Diff #222642)

does this propagate the error into error?

JDevlieghere marked an inline comment as done.Oct 1 2019, 10:25 AM
JDevlieghere added inline comments.
lldb/source/Utility/StructuredData.cpp
48 ↗(On Diff #222642)

No, ParseJSON(std::string) doesn't provide error handling. We probably should add that, but that would mean changing all the call sites. I'd prefer to keep that separate from the JSON change.

vsk accepted this revision.Oct 1 2019, 10:36 AM
This revision is now accepted and ready to land.Oct 1 2019, 10:36 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 10:39 AM