Page MenuHomePhabricator

[Sanitizers] Fix internal_lseek() to work on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Jan 2 2015, 4:28 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Sanitizers] Fix internal_lseek() to work on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
emaste accepted this revision.Jan 2 2015, 6:47 AM
emaste edited edge metadata.
emaste added inline comments.
lib/sanitizer_common/sanitizer_internal_defs.h
84 ↗(On Diff #17759)

This comment is mildly confusing with the addition of FreeBSD to the #if. FreeBSD is "special" in the same way that Mac and Linux/x86-64 are.

The warning above clearly explains the issue. Probably just remove the "Mac and..." comment as it's redundant with the test.

This revision is now accepted and ready to land.Jan 2 2015, 6:47 AM
kutuzov.viktor.84 edited edge metadata.

Comment fixed. Thanks Ed.

samsonov accepted this revision.Jan 7 2015, 8:57 AM
samsonov edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.