Page MenuHomePhabricator

[Alignment][NFC] Adding a max function.
ClosedPublic

Authored by gchatelet on Sep 30 2019, 2:21 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Repository
rL LLVM

Event Timeline

gchatelet created this revision.Sep 30 2019, 2:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2019, 2:21 AM
courbet accepted this revision.Sep 30 2019, 2:23 AM
courbet added inline comments.
llvm/unittests/Support/AlignmentTest.cpp
241 ↗(On Diff #222378)

Maybe add tests for max(Align, Align) to make sure ADL resolves as expected.

This revision is now accepted and ready to land.Sep 30 2019, 2:23 AM
gchatelet updated this revision to Diff 222382.Sep 30 2019, 2:41 AM
  • Address comments
This revision was automatically updated to reflect the committed changes.