Page MenuHomePhabricator

[LitConfig] Silenced notes/warnings on quiet.
ClosedPublic

Authored by nate_chandler on Sep 25 2019, 11:54 AM.

Details

Summary

Lit has a "quiet" option, -q, which is documented to "suppress no error output". Previously, LitConfig displayed notes and warnings when the quiet option was specified. The result was that it was not possible to get only pertinent file/line information to be used by an editor to jump to the location where checks were failing without passing a number of unhelpful locations first. Here, the implementations of LitConfig.note and LitConfig.warning are modified to account for the quiet flag and avoid displaying if the flag has indeed been set.

Diff Detail

Repository
rL LLVM

Event Timeline

nate_chandler created this revision.Sep 25 2019, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 11:54 AM

Definitely in favor. :-)

yln accepted this revision.Oct 7 2019, 4:40 PM
This revision is now accepted and ready to land.Oct 7 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.