This is an archive of the discontinued LLVM Phabricator instance.

[llvm-ar][test] Move MRI tests from "llvm/test/Object/"
ClosedPublic

Authored by gbreynoo on Sep 25 2019, 10:29 AM.

Details

Summary

llvm/test/Object/ contains tests for the ArchiveWriter library, however support for MRI scripts is found in llvm-ar and not the library. This diff moves the MRI related tests and removes those that are duplicates.

Diff Detail

Repository
rL LLVM

Event Timeline

gbreynoo created this revision.Sep 25 2019, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 10:29 AM

There are many tests in this area that use llvm-ar to test the underlying library. It may be better for these also to be in the llvm-ar test directory and have unit tests for specifically testing ArchiveWriter?

grimar accepted this revision.Sep 26 2019, 2:33 AM

This patch looks reasonable. Perhaps wait for someone else to take a look too.

This revision is now accepted and ready to land.Sep 26 2019, 2:33 AM
MaskRay accepted this revision.Sep 26 2019, 2:40 AM
This revision was automatically updated to reflect the committed changes.
llvm/trunk/test/Object/mri-addmod.test