This is an archive of the discontinued LLVM Phabricator instance.

[yaml2elf] - Support describing .stack_sizes sections using unique suffixes.
ClosedPublic

Authored by grimar on Sep 25 2019, 4:11 AM.

Details

Summary

Currently we can't use unique suffixes in section names to describe
stack sizes sections. E.g. '.stack_sizes [1]' will be treated as a regular section.
This happens because we recognize stack sizes section by name and
do not yet drop the suffix before the check.

The patch fixes it.

Diff Detail

Event Timeline

grimar created this revision.Sep 25 2019, 4:11 AM
jhenderson accepted this revision.Sep 25 2019, 4:28 AM

LGTM, with two suggestions.

test/tools/yaml2obj/elf-stack-sizes.yaml
231

Maybe worth saying "describe multiple .stack_sizes sections..."

234

I think "UNIQUE" might be a better prefix here.

This revision is now accepted and ready to land.Sep 25 2019, 4:28 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 5:07 AM