Page MenuHomePhabricator

[unittest] Skip the socket tests if we $TMPDIR is too long.
ClosedPublic

Authored by JDevlieghere on Sep 24 2019, 10:39 AM.

Details

Summary

Adrian added a sanity check to the socket tests to ensure the $TMPDIR is not to long for a socket. While this is great for diagnosing the problem it doesn't really solve the problem for environment where you have no control over that variable such as in CI. I propose to just skip the test in that case similar to what we do for tests that rely on targets that are not currently build, etc.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.Sep 24 2019, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 10:39 AM
Herald added a subscriber: abidh. · View Herald Transcript
aprantl accepted this revision.Sep 24 2019, 12:00 PM
This revision is now accepted and ready to land.Sep 24 2019, 12:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 12:34 PM